Workaround zero size layouts of webview elements#312649
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Apr 27, 2026
Merged
Workaround zero size layouts of webview elements#312649mjbvz merged 2 commits intomicrosoft:mainfrom
mjbvz merged 2 commits intomicrosoft:mainfrom
Conversation
Fixes microsoft#312600 Targeted fix. Seems a bit suspicious the editor layout logic upstream doesn't do this for us
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a workaround in the webview editor pane to treat zero-sized layouts as effectively “not visible”, aiming to prevent webview overlays from remaining visible as tiny, unmovable windows when an editor group is maximized (per #312600).
Changes:
- Update
WebviewEditor.layout()to callsetEditorVisible(...)based on whether the incoming layout dimensions are non-zero.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/webviewPanel/browser/webviewEditor.ts | Toggles the webview editor’s visible state based on layout dimensions to avoid stray webview overlay rendering at 0 size. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <copilot@github.com>
roblourens
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312600
Targeted fix. Seems a bit suspicious the editor layout logic upstream doesn't do this for us