Skip to content

Workaround zero size layouts of webview elements #312649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjbvz merged 2 commits into from
Apr 27, 2026
+6 −0
Merged

Workaround zero size layouts of webview elements #312649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee2b159
Workaround zero size layouts of webview elements
mjbvz Apr 27, 2026
cac0e71
Add guard for repeated calls
mjbvz Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/vs/workbench/contrib/webviewPanel/browser/webviewEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ export class WebviewEditor extends EditorPane {
if (this.webview && this._visible) {
this.setWebviewAnchorElement(this.webview);
}

this.setEditorVisible(dimension.width > 0 && dimension.height > 0);
Comment thread
mjbvz marked this conversation as resolved.
}

public override focus(): void {
Expand All @@ -123,6 +125,10 @@ export class WebviewEditor extends EditorPane {
}

protected override setEditorVisible(visible: boolean): void {
if (visible === this._visible) {
return;
}

this._visible = visible;
if (this.input instanceof WebviewInput && this.webview) {
if (visible) {
Expand Down
Loading