Fix missing memory tool provisioning for GPT-5.4#312652
Open
dpearson2699 wants to merge 6 commits intomicrosoft:mainfrom
Open
Fix missing memory tool provisioning for GPT-5.4#312652dpearson2699 wants to merge 6 commits intomicrosoft:mainfrom
dpearson2699 wants to merge 6 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes deterministic absence of the vscode/memory tool for GPT-5.4 by ensuring ToolName.Memory is treated as a Core tool (excluded from built-in tool grouping), and adds a regression test to lock in the intended grouping behavior.
Changes:
- Reclassifies
ToolName.MemoryfromToolCategory.VSCodeInteractiontoToolCategory.Coreso it won’t be grouped away. - Adds a unit test verifying that VS Code interaction tools are grouped while
memoryremains individually available.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/copilot/src/extension/tools/common/toolNames.ts | Moves ToolName.Memory into the Core category to prevent it from being grouped. |
| extensions/copilot/src/extension/tools/test/node/virtualTools/builtInToolGroupHandler.spec.ts | Adds regression coverage ensuring memory stays ungrouped while VS Code interaction tools are grouped. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the missing
vscode/memorytool provisioning for GPT-5.4 by keepingmemoryas a core tool instead of grouping it under VS Code interaction tools.This change:
ToolName.Memoryas a core tool so it remains directly availableFixes #309245
Validation
npm run compile-extensions-buildnpm --prefix extensions/copilot run test:unit -- src/extension/tools/test/node/virtualTools/builtInToolGroupHandler.spec.tsnode --experimental-strip-types build/hygiene.ts extensions/copilot/src/extension/tools/common/toolNames.ts extensions/copilot/src/extension/tools/test/node/virtualTools/builtInToolGroupHandler.spec.ts