Skip to content

Fix missing memory tool provisioning for GPT-5.4#312652

Open
dpearson2699 wants to merge 6 commits intomicrosoft:mainfrom
dpearson2699:fix/gpt54-memory-tool-provisioning
Open

Fix missing memory tool provisioning for GPT-5.4#312652
dpearson2699 wants to merge 6 commits intomicrosoft:mainfrom
dpearson2699:fix/gpt54-memory-tool-provisioning

Conversation

@dpearson2699
Copy link
Copy Markdown

Summary

Fixes the missing vscode/memory tool provisioning for GPT-5.4 by keeping memory as a core tool instead of grouping it under VS Code interaction tools.

This change:

  • reclassifies ToolName.Memory as a core tool so it remains directly available
  • adds a regression test covering the built-in tool grouping behavior

Fixes #309245

Validation

  • npm run compile-extensions-build
  • npm --prefix extensions/copilot run test:unit -- src/extension/tools/test/node/virtualTools/builtInToolGroupHandler.spec.ts
  • node --experimental-strip-types build/hygiene.ts extensions/copilot/src/extension/tools/common/toolNames.ts extensions/copilot/src/extension/tools/test/node/virtualTools/builtInToolGroupHandler.spec.ts

Copilot AI review requested due to automatic review settings April 27, 2026 02:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes deterministic absence of the vscode/memory tool for GPT-5.4 by ensuring ToolName.Memory is treated as a Core tool (excluded from built-in tool grouping), and adds a regression test to lock in the intended grouping behavior.

Changes:

  • Reclassifies ToolName.Memory from ToolCategory.VSCodeInteraction to ToolCategory.Core so it won’t be grouped away.
  • Adds a unit test verifying that VS Code interaction tools are grouped while memory remains individually available.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
extensions/copilot/src/extension/tools/common/toolNames.ts Moves ToolName.Memory into the Core category to prevent it from being grouped.
extensions/copilot/src/extension/tools/test/node/virtualTools/builtInToolGroupHandler.spec.ts Adds regression coverage ensuring memory stays ungrouped while VS Code interaction tools are grouped.

@dpearson2699
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode/memory tool never provisioned for GPT-5.4 — deterministic absence in both main chat and agent contexts

3 participants