Skip to content

chore: bump Octokit #317632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rzhao271 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: bump Octokit #317632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b269d
chore: bump Octokit
rzhao271 May 20, 2026
42f148a
Apply feedback
rzhao271 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
190 changes: 106 additions & 84 deletions extensions/configuration-editing/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions extensions/configuration-editing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"publisher": "vscode",
"license": "MIT",
"engines": {
"vscode": "^1.0.0"
"vscode": "^1.122.0"
},
"icon": "images/icon.png",
"activationEvents": [
Expand All @@ -31,9 +31,9 @@
"watch-typecheck-web": "tsgo --project ./tsconfig.browser.json --noEmit --watch"
},
"dependencies": {
"@octokit/rest": "^21.1.1",
"@octokit/rest": "^22.0.1",
"jsonc-parser": "^3.2.0",
"tunnel": "^0.0.6"
"undici": "^7.25.0"
},
"capabilities": {
"virtualWorkspaces": true,
Expand Down
2 changes: 1 addition & 1 deletion extensions/configuration-editing/src/browser/net.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

export const agent = undefined;
export const proxyFetch: typeof globalThis.fetch = globalThis.fetch.bind(globalThis);
6 changes: 3 additions & 3 deletions extensions/configuration-editing/src/importExportProfiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { Octokit } from '@octokit/rest';
import * as vscode from 'vscode';
import { basename } from 'path';
import { agent } from './node/net';
import { proxyFetch } from './node/net';

class GitHubGistProfileContentHandler implements vscode.ProfileContentHandler {

Expand All @@ -23,7 +23,7 @@ class GitHubGistProfileContentHandler implements vscode.ProfileContentHandler {
const { Octokit } = await import('@octokit/rest');

return new Octokit({
request: { agent },
request: { fetch: proxyFetch },
userAgent: 'GitHub VSCode',
auth: `token ${token}`
});
Expand Down Expand Up @@ -54,7 +54,7 @@ class GitHubGistProfileContentHandler implements vscode.ProfileContentHandler {
if (!this._public_octokit) {
this._public_octokit = (async () => {
const { Octokit } = await import('@octokit/rest');
return new Octokit({ request: { agent }, userAgent: 'GitHub VSCode' });
return new Octokit({ request: { fetch: proxyFetch }, userAgent: 'GitHub VSCode' });
})();
}
return this._public_octokit;
Expand Down
Loading
Loading