FIx: show error message when running npm install without open workspace#317657
Open
ot7Deity wants to merge 2 commits into
Open
FIx: show error message when running npm install without open workspace#317657ot7Deity wants to merge 2 commits into
ot7Deity wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a silent no-op in the vscode-extras selfhost extension by surfacing an explicit user-facing error when vscode-extras.runNpmInstall is invoked without any open workspace folder, improving feedback in the VS Code workbench.
Changes:
- Show an error notification and early-return when
_runNpmInstall()is executed without an open workspace folder.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a silent failure where running
_runNpmInstall()did nothing if a user did not have a folder open in the workspace. Added a clear error message utilizingvscode.window.showErrorMessageto provide immediate feedback to the user.How to Test
vscode-extras.runNpmInstallcommand (via the status bar or command palette).