feat(agentHost): implement custom agent picker and refactor related components#317719
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a dedicated custom agent picker for Agent Host sessions in the regular workbench chat UI, and refactors Agent Host “custom agents” helper logic so it can be shared across the workbench and Agents Window surfaces.
Changes:
- Adds a workbench chat-input “Agent” chip/picker for Agent Host sessions (hidden in the Agents Window via context keys).
- Introduces
vs/platform/agentHost/common/customAgents.tsto share agent list + selection resolution utilities and updates call sites/tests accordingly. - Consolidates the shared footer menu id for the picker and updates sessions/workbench wiring to avoid duplicate UI.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Wires a new chat-input action view item to render/show the workbench custom agent picker. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostCustomAgentPicker.ts | Adds the new workbench custom agent picker UI and registers a footer “Configure Custom Agents…” action. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.contribution.ts | Contributes OpenAgentHostCustomAgentPickerAction to MenuId.ChatInput for workbench-only rendering. |
| src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostAgents.test.ts | Updates tests to use the new shared getEffectiveAgents helper. |
| src/vs/sessions/contrib/providers/agentHost/test/browser/agentHostAgentPicker.test.ts | Updates tests to use shared storage key + agent resolution helper API. |
| src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts | Switches agent list computation to the shared platform helper. |
| src/vs/sessions/contrib/providers/agentHost/browser/agentHostAgents.ts | Removes now-duplicated sessions-layer implementation of getEffectiveAgents. |
| src/vs/sessions/contrib/providers/agentHost/browser/agentHostAgentPicker.ts | Uses shared helpers and imports the shared footer menu id from workbench code. |
| src/vs/platform/agentHost/common/customAgents.ts | New shared helpers for computing effective agents + resolving selection + shared storage key. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: DonJayamanne <1948812+DonJayamanne@users.noreply.github.com>
aiday-mar
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.