Skip to content

fix: allow localhost in chat.agent.allowedNetworkDomains #317732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thonhaus wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −1
Open

fix: allow localhost in chat.agent.allowedNetworkDomains #317732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e59e5
fix for https://github.com/microsoft/vscode/issues/314339
thonhaus May 21, 2026
941f839
added tests
thonhaus May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/platform/networkFilter/common/domainMatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function extractDomainPattern(pattern: string): string {
* @returns `true` if the domain matches the pattern.
*/
export function matchesDomainPattern(domain: string, pattern: string): boolean {
const normalizedPattern = normalizeDomain(extractDomainPattern(pattern), pattern.includes('://'));
const normalizedPattern = normalizeDomain(extractDomainPattern(pattern), true);
if (!normalizedPattern) {
return false;
}
Expand Down
10 changes: 10 additions & 0 deletions src/vs/platform/networkFilter/test/common/domainMatcher.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,11 @@ suite('domainMatcher', () => {
test('returns false for invalid pattern', () => {
assert.strictEqual(matchesDomainPattern('example.com', ''), false);
});

test('matches localhost pattern', () => {
assert.strictEqual(matchesDomainPattern('localhost', 'localhost'), true);
assert.strictEqual(matchesDomainPattern('localhost', 'other.com'), false);
});
});

suite('extractDomainFromUri', () => {
Expand Down Expand Up @@ -184,5 +189,10 @@ suite('domainMatcher', () => {
assert.strictEqual(isDomainAllowed('api.example.com', ['*.example.com'], []), true);
assert.strictEqual(isDomainAllowed('api.example.com', [], ['*.example.com']), false);
});

test('localhost is allowed when explicitly listed', () => {
assert.strictEqual(isDomainAllowed('localhost', ['localhost'], []), true);
assert.strictEqual(isDomainAllowed('localhost', [], ['localhost']), false);
});
});
});
Loading