Skip to content

Commit 7ba413c

Browse files
committed
Addressing comments
1 parent 86fca70 commit 7ba413c

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

src/AppInstallerCLICore/Commands/DscUserSettingsFileResource.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,13 @@ namespace AppInstaller::CLI
3333
_userSettingsPath(UserSettings::SettingsFilePath())
3434
{
3535
const auto& action = Input.Action();
36-
if (action.has_value() && (Utility::CaseInsensitiveEquals(action.value(), ACTION_FULL) || Utility::CaseInsensitiveEquals(action.value(), ACTION_PARTIAL)))
36+
if (action.has_value() && Utility::CaseInsensitiveEquals(action.value(), ACTION_FULL))
3737
{
38-
Output.Action(Input.Action());
38+
Output.Action(ACTION_FULL);
39+
}
40+
else
41+
{
42+
Output.Action(ACTION_PARTIAL);
3943
}
4044
}
4145

src/AppInstallerCLIE2ETests/DSCv3UserSettingsFileResourceCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ public void UserSettingsFile_Set_ActionIsPartialByDefault()
138138

139139
// Assert that the settings are added
140140
Assert.IsNotNull(setOutput);
141-
Assert.IsNull(setOutput.Action);
141+
Assert.AreEqual(setOutput.Action, ActionPropertyValuePartial);
142142
AssertMockProperties(setOutput.Settings, "mock");
143143
AssertSettingsAreEqual(expected, setOutput.Settings);
144144
AssertDiffState(setDiff, [ SettingsPropertyName ]);

0 commit comments

Comments
 (0)