Skip to content

Commit 86fca70

Browse files
committed
Case in
1 parent 24bb391 commit 86fca70

2 files changed

Lines changed: 15 additions & 10 deletions

File tree

src/AppInstallerCLICore/Commands/DscUserSettingsFileResource.cpp

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
#include "DscUserSettingsFileResource.h"
55
#include "DscComposableObject.h"
66
#include "Resources.h"
7+
#include "AppInstallerStrings.h"
78

89
using namespace AppInstaller::Utility::literals;
910
using namespace AppInstaller::Settings;
@@ -31,14 +32,18 @@ namespace AppInstaller::CLI
3132
Input(json, ignoreFieldRequirements),
3233
_userSettingsPath(UserSettings::SettingsFilePath())
3334
{
35+
const auto& action = Input.Action();
36+
if (action.has_value() && (Utility::CaseInsensitiveEquals(action.value(), ACTION_FULL) || Utility::CaseInsensitiveEquals(action.value(), ACTION_PARTIAL)))
37+
{
38+
Output.Action(Input.Action());
39+
}
3440
}
3541

3642
const UserSettingsFileResourceObject Input;
3743
UserSettingsFileResourceObject Output;
3844

3945
void Get()
4046
{
41-
Output.Action(ACTION_PARTIAL);
4247
Output.Settings(GetUserSettings());
4348
}
4449

@@ -64,7 +69,7 @@ namespace AppInstaller::CLI
6469
THROW_HR_IF(E_UNEXPECTED, !Input.Settings().has_value());
6570
if (!_resolvedInputUserSettings)
6671
{
67-
if(Input.Action() == ACTION_FULL)
72+
if(Input.Action().has_value() && Utility::CaseInsensitiveEquals(Input.Action().value(), ACTION_FULL))
6873
{
6974
_resolvedInputUserSettings = Input.Settings();
7075
}

src/AppInstallerCLIE2ETests/DSCv3UserSettingsFileResourceCommand.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public void UserSettingsFile_Get()
7070
var getOutput = Get(new ());
7171

7272
Assert.IsNotNull(getOutput);
73-
Assert.AreEqual(ActionPropertyValuePartial, getOutput.Action);
73+
Assert.IsNull(getOutput.Action);
7474
AssertSettingsAreEqual(expected, getOutput.Settings);
7575
}
7676

@@ -90,7 +90,7 @@ public void UserSettingsFile_Set_NoDiff(string action)
9090
var expected = GetCurrentUserSettings();
9191

9292
Assert.IsNotNull(setOutput);
93-
Assert.AreEqual(ActionPropertyValuePartial, setOutput.Action);
93+
Assert.AreEqual(action, setOutput.Action);
9494
AssertSettingsAreEqual(expected, setOutput.Settings);
9595
AssertDiffState(setDiff, []);
9696
}
@@ -114,7 +114,7 @@ public void UserSettingsFile_Set_AddFields(string action)
114114

115115
// Assert that the settings are added
116116
Assert.IsNotNull(setOutput);
117-
Assert.AreEqual(ActionPropertyValuePartial, setOutput.Action);
117+
Assert.AreEqual(action, setOutput.Action);
118118
AssertMockProperties(setOutput.Settings, "mock");
119119
AssertSettingsAreEqual(expected, setOutput.Settings);
120120
AssertDiffState(setDiff, [ SettingsPropertyName ]);
@@ -138,7 +138,7 @@ public void UserSettingsFile_Set_ActionIsPartialByDefault()
138138

139139
// Assert that the settings are added
140140
Assert.IsNotNull(setOutput);
141-
Assert.AreEqual(ActionPropertyValuePartial, setOutput.Action);
141+
Assert.IsNull(setOutput.Action);
142142
AssertMockProperties(setOutput.Settings, "mock");
143143
AssertSettingsAreEqual(expected, setOutput.Settings);
144144
AssertDiffState(setDiff, [ SettingsPropertyName ]);
@@ -168,7 +168,7 @@ public void UserSettingsFile_Set_UpdateFields(string action)
168168

169169
// Assert that the settings are updated
170170
Assert.IsNotNull(setOutput);
171-
Assert.AreEqual(ActionPropertyValuePartial, setOutput.Action);
171+
Assert.AreEqual(action, setOutput.Action);
172172
AssertMockProperties(setOutput.Settings, "mock_new");
173173
AssertSettingsAreEqual(expected, setOutput.Settings);
174174
AssertDiffState(setDiff, [ SettingsPropertyName ]);
@@ -198,7 +198,7 @@ public void UserSettingsFile_Test_InDesiredState(string action)
198198

199199
// Assert that the settings are in desired state
200200
Assert.IsNotNull(testOutput);
201-
Assert.AreEqual(ActionPropertyValuePartial, testOutput.Action);
201+
Assert.AreEqual(action, testOutput.Action);
202202
AssertMockProperties(testOutput.Settings, "mock");
203203
AssertSettingsAreEqual(expected, testOutput.Settings);
204204
Assert.IsTrue(testOutput.InDesiredState);
@@ -229,7 +229,7 @@ public void UserSettingsFile_Test_NotInDesiredState(string action)
229229

230230
// Assert that the settings are not in desired state
231231
Assert.IsNotNull(testOutput);
232-
Assert.AreEqual(ActionPropertyValuePartial, testOutput.Action);
232+
Assert.AreEqual(action, testOutput.Action);
233233
AssertMockProperties(testOutput.Settings, "mock_set");
234234
AssertSettingsAreEqual(expected, testOutput.Settings);
235235
Assert.IsFalse(testOutput.InDesiredState);
@@ -246,7 +246,7 @@ public void UserSettingsFile_Export()
246246
var exportOutput = Export(new ());
247247

248248
Assert.IsNotNull(exportOutput);
249-
Assert.AreEqual(ActionPropertyValuePartial, exportOutput.Action);
249+
Assert.IsNull(exportOutput.Action);
250250
AssertSettingsAreEqual(expected, exportOutput.Settings);
251251
}
252252

0 commit comments

Comments
 (0)