Ensure required modules for configuration export and import#5521
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
JohnMcPMS
reviewed
Jun 12, 2025
|
|
||
| ValueSet settings; | ||
| settings.Insert(s_Setting_PowerShellGet_ModuleName, PropertyValue::CreateString(moduleName)); | ||
| settings.Insert(s_Setting_WinGetPackage_Id, PropertyValue::CreateString(L"Microsoft.PowerShell")); |
Member
There was a problem hiding this comment.
Constants?
Also, we should consider extracting this from / filtering out of the package results.
|
|
||
| // Apply the unit to make sure it's on the system. | ||
| context.Reporter.Info() << Resource::String::ConfigurationExportInstallRequiredModule(Utility::LocIndView{ "Microsoft PowerShell Package" }) << std::endl; | ||
| auto applyPowerShellResult = ApplyUnit(context, powerShellPackageUnit); |
Member
There was a problem hiding this comment.
We always apply it without testing?
Contributor
Author
There was a problem hiding this comment.
For the wingetpackage dsc resource, it tests it (in the resource implementation) before applying. So I'm just applying it to save 2 calls.
JohnMcPMS
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow