Skip to content

Fix AV in portable flow #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcPMS merged 2 commits into from
Jun 15, 2025
Merged

Fix AV in portable flow #5526

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27143e9
Don't deref potential null
JohnMcPMS Jun 13, 2025
b1405e3
Ensure that we actually have the value present
JohnMcPMS Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/AppInstallerCLICore/Workflows/PortableFlow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,10 @@ namespace AppInstaller::CLI::Workflow
{
Manifest::ScopeEnum scope = Manifest::ScopeEnum::Unknown;
bool isUpdate = WI_IsFlagSet(context.GetFlags(), Execution::ContextFlag::InstallerExecutionUseUpdate);
if (isUpdate)
auto installedVersion = context.Get<Execution::Data::InstalledPackageVersion>();
if (isUpdate && installedVersion)
{
IPackageVersion::Metadata installationMetadata = context.Get<Execution::Data::InstalledPackageVersion>()->GetMetadata();
IPackageVersion::Metadata installationMetadata = installedVersion->GetMetadata();
auto installerScopeItr = installationMetadata.find(Repository::PackageVersionMetadata::InstalledScope);
if (installerScopeItr != installationMetadata.end())
{
Expand Down
Loading