Skip to content

Weekly Permissions sync 2025-08-06#1216

Closed
marabooy wants to merge 2 commits intodevfrom
permissions-update/2025-08-06
Closed

Weekly Permissions sync 2025-08-06#1216
marabooy wants to merge 2 commits intodevfrom
permissions-update/2025-08-06

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

@marabooy marabooy commented Aug 6, 2025

Weekly Permissions sync 2025-08-06

@marabooy marabooy requested a review from a team as a code owner August 6, 2025 00:30
Copilot AI review requested due to automatic review settings August 28, 2025 20:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new user authentication method permissions for various authentication types including passkeys, passwords, phone, platform credentials, QR codes, software/hardware OATH, TAP, Windows Hello, email, external methods, and Microsoft Authenticator app. It appears to be part of a routine weekly permissions synchronization process.

  • Adds comprehensive read/write permissions for multiple user authentication methods
  • Includes both delegated and application permission schemes for most authentication types
  • Maintains consistent structure and resource app ID across all new permission entries

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +15433 to +15438
"id": "",
"scheme": "DelegatedWork",
"environment": "public",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "ea890292-c8c8-4433-b5ea-b09d0668e1a6"
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'id' field is empty for all new permission entries. This could cause issues with permission identification and tracking. Each permission entry should have a unique identifier.

Copilot uses AI. Check for mistakes.
Comment on lines +16065 to 16077
"UserAuthMethod-Passkey.Read": [
{
"id": "",
"scheme": "DelegatedWork",
"environment": "public",
"isHidden": true,
"isEnabled": true,
"resourceAppId": "ea890292-c8c8-4433-b5ea-b09d0668e1a6"
}
],
"UserAuthMethod-Passkey.Read.All": [
{
"id": "14195339-1fe4-48a7-a0d3-a39eb9fd8958",
Copy link

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicate definition of 'UserAuthMethod-Passkey.Read.All' - one at line 15431 and another at line 16075. This creates conflicting permission entries that could cause runtime issues.

Copilot uses AI. Check for mistakes.
@jasonjoh
Copy link
Copy Markdown
Member

Closing this as a later PR added these permissions.

@jasonjoh jasonjoh closed this Aug 28, 2025
@jasonjoh jasonjoh deleted the permissions-update/2025-08-06 branch August 28, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants