Skip to content

Weekly Permissions sync 2025-08-18#1228

Closed
marabooy wants to merge 0 commit intodevfrom
permissions-update/2025-08-18
Closed

Weekly Permissions sync 2025-08-18#1228
marabooy wants to merge 0 commit intodevfrom
permissions-update/2025-08-18

Conversation

@marabooy
Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2025-08-18

Copilot AI review requested due to automatic review settings August 18, 2025 00:21
@marabooy marabooy requested a review from a team as a code owner August 18, 2025 00:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a weekly permissions synchronization update for 2025-08-18, focusing on permission restructuring and new authentication method permissions. The changes include removing legacy agent permissions, introducing granular user authentication method permissions, and updating various API endpoint configurations.

  • Removed deprecated AgentApplication.Create and AgentIdentity.Create permissions
  • Added comprehensive granular user authentication method permissions (email, external, hardware OATH, etc.)
  • Updated existing permission configurations and API endpoint mappings

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
permissions/new/permissions.json Removes agent permissions, adds granular auth method permissions, updates API endpoints and authorization schemes
permissions/new/ProvisioningInfo.json Adds provisioning information for new authentication method permissions and updates existing permission configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

"isHidden": false,
"isHidden": true,
"isEnabled": true,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceAppId value "00000003-0000-0000-c000-00000000000" appears to be missing the final digit. Microsoft Graph's standard resource app ID is "00000003-0000-0000-c000-000000000000" (with 12 zeros at the end).

Suggested change
"resourceAppId": "00000003-0000-0000-c000-00000000000"
"resourceAppId": "00000003-0000-0000-c000-000000000000"

Copilot uses AI. Check for mistakes.
"environment": "public",
"isHidden": true,
"isEnabled": false,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceAppId value "00000003-0000-0000-c000-00000000000" appears to be missing the final digit. Microsoft Graph's standard resource app ID is "00000003-0000-0000-c000-000000000000" (with 12 zeros at the end).

Suggested change
"resourceAppId": "00000003-0000-0000-c000-00000000000"
"resourceAppId": "00000003-0000-0000-c000-000000000000"

Copilot uses AI. Check for mistakes.
"environment": "public",
"isHidden": true,
"isEnabled": false,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceAppId value "00000003-0000-0000-c000-00000000000" appears to be missing the final digit. Microsoft Graph's standard resource app ID is "00000003-0000-0000-c000-000000000000" (with 12 zeros at the end).

Suggested change
"resourceAppId": "00000003-0000-0000-c000-00000000000"
"resourceAppId": "00000003-0000-0000-c000-000000000000"

Copilot uses AI. Check for mistakes.
"environment": "public",
"isHidden": true,
"isEnabled": false,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceAppId value "00000003-0000-0000-c000-00000000000" appears to be missing the final digit. Microsoft Graph's standard resource app ID is "00000003-0000-0000-c000-000000000000" (with 12 zeros at the end).

Suggested change
"resourceAppId": "00000003-0000-0000-c000-00000000000"
"resourceAppId": "00000003-0000-0000-c000-000000000000"

Copilot uses AI. Check for mistakes.
"environment": "public",
"isHidden": true,
"isEnabled": false,
"resourceAppId": "00000003-0000-0000-c000-00000000000"
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resourceAppId value "00000003-0000-0000-c000-00000000000" appears to be missing the final digit. Microsoft Graph's standard resource app ID is "00000003-0000-0000-c000-000000000000" (with 12 zeros at the end).

Suggested change
"resourceAppId": "00000003-0000-0000-c000-00000000000"
"resourceAppId": "00000003-0000-0000-c000-000000000000"

Copilot uses AI. Check for mistakes.
@jasonjoh jasonjoh closed this Aug 28, 2025
@jasonjoh jasonjoh force-pushed the permissions-update/2025-08-18 branch from ce696e3 to 90c1cb1 Compare August 28, 2025 20:38
@jasonjoh jasonjoh deleted the permissions-update/2025-08-18 branch August 28, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants