Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs a weekly permissions sync, adding new API endpoint permissions for workHoursAndLocations settings, a Copilot retrieval endpoint, and a Cloud PC client usage report endpoint.
- Adds multiple permission entries for the new
/me/settings/workHoursAndLocationsand/users/{id}/settings/workHoursAndLocationsendpoints across various HTTP methods (GET, POST, PUT, DELETE, PATCH) - Adds permission for the
/copilot/retrievalendpoint with DelegatedWork scheme - Adds permission for the
/deviceManagement/virtualEndpoint/report/retrieveCloudPcClientUsageReportendpoint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ], | ||
| "paths": { | ||
| "/me/settings/workHoursAndLocations": "", | ||
| "/me/settings/workHoursAndLocations/occurrencesView(startDateTime={value},endDateTime={value})": "least=DelegatedWork", |
There was a problem hiding this comment.
Inconsistent casing: the function parameter uses 'startDateTime' (camelCase), but in line 5733 the same path uses an empty string value while line 5273 uses 'least=DelegatedWork'. This inconsistency between two blocks defining the same paths with the same method and scheme suggests one may be incorrect or redundant.
| "GET" | ||
| ], | ||
| "paths": { | ||
| "/me/settings/workHoursAndLocations": "", |
There was a problem hiding this comment.
This path entry at line 5272 has an empty string value, but the same path at line 5833 (PATCH method) and line 29835 (GET method) has 'least=DelegatedWork'. The inconsistency suggests these duplicate entries may need consolidation or clarification of the permission requirements.
| "/users/{id}/settings/workHoursAndLocations/occurrences/{id}": "least=DelegatedWork", | ||
| "/users/{id}/settings/workHoursAndLocations/recurrences/{id}": "least=DelegatedWork" |
There was a problem hiding this comment.
[nitpick] Path uses {id} placeholder twice in the same path (once for user ID and once for the resource ID). This ambiguous naming could lead to confusion. Consider using more descriptive placeholders like {userId} and {occurrenceId} or {recurrenceId} to distinguish between the two identifiers.
Weekly Permissions sync 2025-11-15