Address review feedback

dkershaw10 · dkershaw10 · commit 09f8a57ade3a · 2025-03-18T11:11:14.000Z
diff --git a/quickstart-templates/security-group-assign-azure-role/main.bicep b/quickstart-templates/security-group-assign-azure-role/main.bicep
@@ -17,7 +17,7 @@ resource managedIdentities 'Microsoft.ManagedIdentity/userAssignedIdentities@202
   }
 ]
 
-// Storage resource that the clinet services need access to
+// Storage resource that the client services need access to
 resource storage 'Microsoft.Storage/storageAccounts@2023-05-01' existing = {
   name: storageName
 }
@@ -29,7 +29,9 @@ resource storageBlobReadersGroup 'Microsoft.Graph/groups@v1.0' = {
   mailNickname: uniqueString(groupName)
   securityEnabled: true
   uniqueName: groupName
-  members: [for (mi, i) in clientServiceList: managedIdentities[i].properties.principalId]
+  members: {
+    relationships: [for (mi, i) in clientServiceList: managedIdentities[i].properties.principalId]
+  }
 }
 
 @description('Specify the storage blob reader role definition ID')

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ resource managedIdentities 'Microsoft.ManagedIdentity/userAssignedIdentities@202`
`17`	`17`	`}`
`18`	`18`	`]`
`19`	`19`
`20`		`-// Storage resource that the clinet services need access to`
	`20`	`+// Storage resource that the client services need access to`
`21`	`21`	`resource storage 'Microsoft.Storage/storageAccounts@2023-05-01' existing = {`
`22`	`22`	`name: storageName`
`23`	`23`	`}`
`@@ -29,7 +29,9 @@ resource storageBlobReadersGroup 'Microsoft.Graph/groups@v1.0' = {`
`29`	`29`	`mailNickname: uniqueString(groupName)`
`30`	`30`	`securityEnabled: true`
`31`	`31`	`uniqueName: groupName`
`32`		`- members: [for (mi, i) in clientServiceList: managedIdentities[i].properties.principalId]`
	`32`	`+ members: {`
	`33`	`+ relationships: [for (mi, i) in clientServiceList: managedIdentities[i].properties.principalId]`
	`34`	`+ }`
`33`	`35`	`}`
`34`	`36`
`35`	`37`	`@description('Specify the storage blob reader role definition ID')`