Skip to content

fix: remove previewBranch parameter and align deploy stage condition#2526

Merged
ramsessanchez merged 4 commits intomainfrom
fix/remove-ci-github-deploy
Apr 10, 2026
Merged

fix: remove previewBranch parameter and align deploy stage condition#2526
ramsessanchez merged 4 commits intomainfrom
fix/remove-ci-github-deploy

Conversation

@jingjingjia-ms
Copy link
Copy Markdown
Contributor

@jingjingjia-ms jingjingjia-ms commented Dec 19, 2025

The deploy stage condition referenced a previewBranch parameter that became unnecessary after removing deploy_github. This caused the deploy stage to execute on previewBranch pushes while immediately skipping all jobs — confusing and misleading.

Changes

  • Removed previewBranch parameter — no longer referenced anywhere in the pipeline
  • Simplified deploy stage condition — now matches the deploy_maven job's condition exactly:
    # Before
    condition: and(or(contains(variables['build.sourceBranch'], 'refs/tags/v'), eq(variables['build.sourceBranch'], '${{ parameters.previewBranch }}')), succeeded())
    
    # After
    condition: and(contains(variables['build.sourceBranch'], 'refs/tags/v'), succeeded())

@jingjingjia-ms jingjingjia-ms requested a review from a team as a code owner December 19, 2025 00:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the GitHub release deployment job from the CI build pipeline so that GitHub deployments are handled by the release process instead.

Changes:

  • Deleted the deploy_github deployment job from the deploy stage in the Azure Pipelines CI definition.
  • Left the Maven deployment (deploy_maven) as the remaining deployment job in the deploy stage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI changed the title fix: remove deploy github job from ci-build fix: remove previewBranch parameter and align deploy stage condition Apr 8, 2026
Copilot AI requested a review from ramsessanchez April 8, 2026 23:56
@ramsessanchez ramsessanchez enabled auto-merge April 10, 2026 23:32
@ramsessanchez ramsessanchez self-requested a review April 10, 2026 23:35
@ramsessanchez ramsessanchez merged commit 53507c0 into main Apr 10, 2026
11 of 12 checks passed
@ramsessanchez ramsessanchez deleted the fix/remove-ci-github-deploy branch April 10, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants