fix: define ACR variables at pipeline scope

Keep the publishing step template parameter-free while declaring registry and service connection variables in the Azure Pipelines that consume it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: af247b04-ecf8-4873-a78c-33d6437bb0d0

Author: Microsoft Graph DevX Tooling

.azure-pipelines/ci-build.yml

@@ -27,7 +27,9 @@ variables:
   BuildAgent: ${{ parameters.BuildAgent }}
   GitUserEmail: "GraphTooling@service.microsoft.com"
   GitUserName: "Microsoft Graph DevX Tooling"
+  ACR_SERVICE_CONNECTION: 'ACR Images Push Service Connection'
   REGISTRY: 'msgraphprodregistry.azurecr.io'
+  REGISTRY_NAME: 'msgraphprodregistry'
   IMAGE_NAME: 'public/microsoftgraph/powershell'
 
 trigger:

.azure-pipelines/common-templates/publish-psresources-acr.yml

@@ -1,12 +1,6 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License.
 
-variables:
-  ACR_SERVICE_CONNECTION: 'ACR Images Push Service Connection'
-  REGISTRY: 'msgraphprodregistry.azurecr.io'
-  REGISTRY_NAME: 'msgraphprodregistry'
-  ARTIFACT_PATH: '$(System.DefaultWorkingDirectory)/drop'
-
 steps:
   - task: AzurePowerShell@5
     displayName: 'Publish PowerShell packages to ACR'
@@ -65,10 +59,11 @@ steps:
           }
         }
 
-        $packages = @(Get-ChildItem -Path '$(ARTIFACT_PATH)' -Recurse -File -Filter 'Microsoft.Graph*.nupkg' |
+        $artifactPath = '$(System.DefaultWorkingDirectory)/drop'
+        $packages = @(Get-ChildItem -Path $artifactPath -Recurse -File -Filter 'Microsoft.Graph*.nupkg' |
           ForEach-Object { Get-PackageMetadata -PackagePath $_.FullName })
         if ($packages.Count -eq 0) {
-          throw "No Microsoft Graph PowerShell packages were found under '$(ARTIFACT_PATH)'."
+          throw "No Microsoft Graph PowerShell packages were found under '$artifactPath'."
         }
 
         $packages = $packages | Sort-Object @{

.azure-pipelines/sdk-release.yml

@@ -27,7 +27,9 @@ variables:
   BuildAgent: ${{ parameters.BuildAgent }}
   GitUserEmail: "GraphTooling@service.microsoft.com"
   GitUserName: "Microsoft Graph DevX Tooling"
+  ACR_SERVICE_CONNECTION: 'ACR Images Push Service Connection'
   REGISTRY: 'msgraphprodregistry.azurecr.io'
+  REGISTRY_NAME: 'msgraphprodregistry'
   IMAGE_NAME: 'public/microsoftgraph/powershell'
   PREVIEW_BRANCH: 'refs/heads/main'  # Updated to target your branch