Skip to content

Commit 6d120bf

Browse files
authored
Fix: Revert class field changes and correct type mismatch in ReversedDequeTest
- Reverted ProcessManager.unfinishedProcessesCache from ConcurrentHashMap to ConcurrentMap (class field should use interface type) - Reverted MBeanInfoBuilder fields from LinkedList to List (class fields should use interface types) - Corrected ReversedDequeTest.newInstance() return variable from LinkedList to Deque (the 'of()' method returns ReversedDeque, not LinkedList)"
1 parent 74952b7 commit 6d120bf

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

microsphere-java-core/src/main/java/io/microsphere/management/builder/MBeanInfoBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,16 @@ public class MBeanInfoBuilder extends MBeanDescribableBuilder<MBeanInfoBuilder>
5454
String className;
5555

5656
@Nullable
57-
LinkedList<MBeanAttributeInfoBuilder> attributeBuilders = new LinkedList<>();
57+
List<MBeanAttributeInfoBuilder> attributeBuilders = new LinkedList<>();
5858

5959
@Nullable
60-
LinkedList<MBeanOperationInfoBuilder> operationBuilders = new LinkedList<>();
60+
List<MBeanOperationInfoBuilder> operationBuilders = new LinkedList<>();
6161

6262
@Nullable
63-
LinkedList<MBeanConstructorInfoBuilder> constructorBuilders = new LinkedList<>();
63+
List<MBeanConstructorInfoBuilder> constructorBuilders = new LinkedList<>();
6464

6565
@Nullable
66-
LinkedList<MBeanNotificationInfoBuilder> notificationBuilders = new LinkedList<>();
66+
List<MBeanNotificationInfoBuilder> notificationBuilders = new LinkedList<>();
6767

6868
public MBeanInfoBuilder attribute(String attributeName, Class<?> attributeType, Consumer<MBeanAttributeInfoBuilder> builderConsumer) {
6969
MBeanAttributeInfoBuilder builder = MBeanAttributeInfoBuilder.attribute(attributeType).name(attributeName);

microsphere-java-core/src/main/java/io/microsphere/process/ProcessManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public class ProcessManager {
4444
*/
4545
public static final ProcessManager INSTANCE = new ProcessManager();
4646

47-
final ConcurrentHashMap<Process, String> unfinishedProcessesCache = newConcurrentHashMap();
47+
final ConcurrentMap<Process, String> unfinishedProcessesCache = newConcurrentHashMap();
4848

4949
private ProcessManager() {
5050
}

microsphere-java-core/src/test/java/io/microsphere/collection/ReversedDequeTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class ReversedDequeTest extends MutableDequeTest<Deque<Object>> {
3939

4040
@Override
4141
protected Deque<Object> newInstance() {
42-
LinkedList<Object> reversedDeque = of(of(new LinkedList<>()));
42+
Deque<Object> reversedDeque = of(of(new LinkedList<>()));
4343
return reversedDeque;
4444
}
4545

0 commit comments

Comments
 (0)