Dev 1.x#3
Conversation
Use Collections.emptyList/emptySet in ThrowableLogging test for compatibility and to avoid Java 9+ APIs. Update parent POM dependency versions and management: set slf4j to 1.7.36, logback to 1.2.12, bump junit-jupiter to 5.14.3, and consolidate JUnit BOM and junit entries in dependencyManagement. Adjust root POM revision to 0.1.0-SNAPSHOT and remove the explicit java.version property.
Change the Codecov badge URL in README.md to reference the dev-1.x branch instead of dev so the coverage badge points to the correct branch after the branch rename.
Rework the modules table in README: reorder entries for clarity, simplify module descriptions, and add microsphere-logging-logback. Update microsphere-logging-core and microsphere-logging-test descriptions to reflect core features and test extensions (JUnit4/Jupiter). Formatting of the table was adjusted for alignment.
🤖 Augment PR SummarySummary: This PR retargets the project to a new Changes:
Technical Notes: Workflow and dependency changes appear aimed at supporting older JDKs while aligning release automation with the new 1.x branch strategy. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| matrix: | ||
| java: [ '17' , '21' , '25' ] | ||
| java: [ '8', '11' , '17' , '21' ,' 25' ] | ||
| steps: |
There was a problem hiding this comment.
The Java matrix includes ' 25' with a leading space, which will be passed verbatim to actions/setup-java and is likely to make that matrix entry fail to resolve a JDK version.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| throw new RuntimeException("For testing..."); | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file now has no trailing newline (\ No newline at end of file), which can cause noisy diffs and may fail formatting/checkstyle rules if enforced in CI.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
1 participant
This pull request makes several changes to align the project with a new 1.x development and release branch, updates dependency versions, and improves documentation and test code. The most important changes are grouped below.
Branch and Workflow Updates
.github/workflows/maven-build.ymland.github/workflows/maven-publish.ymlto trigger on the newdev-1.xandrelease-1.xbranches instead of the previousdev,main, andreleasebranches. Also updated the default publish version to1.0.0-SNAPSHOTand expanded Java version matrix to include Java 8 and 11. [1] [2]README.mdto track thedev-1.xbranch.Dependency and Build Configuration
microsphere-logging-parent/pom.xml: downgradedslf4jto 1.7.36, setlogbackto 1.2.12, and fixedjunit-jupiterto 5.14.3. Added explicit JUnit BOM and JUnit dependencies to dependency management. [1] [2]pom.xmlto0.1.0-SNAPSHOTand removed the Java version property (was previously set to 17).Documentation Improvements
README.mdto clarify the purpose of each module and reflect the current project structure.Test Code Improvements
ThrowableLogging.javatest class, replaced usage ofList.of()andSet.of()withemptyList()andemptySet()for compatibility with older Java versions. [1] [2]setLoggerLevelmethod implementation in the same test class.