Skip to content

Commit 881b113

Browse files
renemadsenclaude
andcommitted
fix(visual-editor): restore original element-types array, keep only DB ID normalization
The previous rewrite accidentally changed translation keys (None→InfoBox, Text (TextSingleLine)→Text), color hex values, color IDs, preview image paths, and array order. These broke the Danish translation lookup in Playwright tests and the color matching logic. Restore the original eformVisualEditorElementTypes array and eformVisualEditorElementColors exactly as they were. Only addition: the dbFieldTypes normalization parameter on getTranslatedTypes(), which remaps hardcoded enum ordinals to actual DB IDs when passed. The container loads DB field types once on init, passes them to the modal via MAT_DIALOG_DATA, and the modal passes them through to getTranslatedTypes(). Falls back to enum ordinals if not available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 517f252 commit 881b113

File tree

1 file changed

+85
-59
lines changed

1 file changed

+85
-59
lines changed

eform-client/src/app/modules/eforms/eform-visual-editor/const/eform-visual-editor-element-types.ts

Lines changed: 85 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,11 @@ export const eformVisualEditorElementTypes: EformVisualEditorFieldTypeModel[] =
4343
'../../../../../../../assets/images/visual-editor-preview/single-select.png',
4444
},
4545
{
46-
id: EformFieldTypesEnum.MultiSelect,
47-
name: 'MultiSelect',
48-
description: 'Multi selection list',
49-
previewImage:
50-
'../../../../../../../assets/images/visual-editor-preview/multi-select.png',
51-
},
52-
{
53-
id: EformFieldTypesEnum.Date,
54-
name: 'Date',
55-
description: 'Simple date selection field',
46+
id: EformFieldTypesEnum.Comment,
47+
name: 'Comment',
48+
description: 'Simple comment field',
5649
previewImage:
57-
'../../../../../../../assets/images/visual-editor-preview/date.png',
50+
'../../../../../../../assets/images/visual-editor-preview/comment.png',
5851
},
5952
{
6053
id: EformFieldTypesEnum.Number,
@@ -63,115 +56,148 @@ export const eformVisualEditorElementTypes: EformVisualEditorFieldTypeModel[] =
6356
previewImage:
6457
'../../../../../../../assets/images/visual-editor-preview/number.png',
6558
},
66-
{
67-
id: EformFieldTypesEnum.Text,
68-
name: 'Text',
69-
description: 'Text field',
70-
previewImage:
71-
'../../../../../../../assets/images/visual-editor-preview/text.png',
72-
},
73-
{
74-
id: EformFieldTypesEnum.Comment,
75-
name: 'Comment',
76-
description: 'Simple comment field',
77-
previewImage:
78-
'../../../../../../../assets/images/visual-editor-preview/comment.png',
79-
},
8059
{
8160
id: EformFieldTypesEnum.Picture,
8261
name: 'Picture',
8362
description: 'Simple picture field',
8463
previewImage:
85-
'../../../../../../../assets/images/visual-editor-preview/picture.png',
64+
'../../../../../../../assets/images/visual-editor-preview/picture-screenshot.png',
8665
},
8766
{
8867
id: EformFieldTypesEnum.None,
89-
name: 'InfoBox',
90-
description: 'Simple info box field',
68+
name: 'None',
69+
description: 'Simple text to be displayed',
9170
previewImage:
9271
'../../../../../../../assets/images/visual-editor-preview/infobox.png',
9372
},
9473
{
95-
id: EformFieldTypesEnum.Timer,
96-
name: 'Timer',
97-
description: 'Timer field',
74+
id: EformFieldTypesEnum.Date,
75+
name: 'Date',
76+
description: 'Date selection',
9877
previewImage:
99-
'../../../../../../../assets/images/visual-editor-preview/timer.png',
78+
'../../../../../../../assets/images/visual-editor-preview/date.png',
10079
},
10180
{
10281
id: EformFieldTypesEnum.SaveButton,
10382
name: 'SaveButton',
104-
description: 'Save button field',
83+
description: 'Save eForm.',
10584
previewImage:
106-
'../../../../../../../assets/images/visual-editor-preview/save-button.png',
85+
'../../../../../../../assets/images/visual-editor-preview/save-screenshot.png',
10786
},
10887
{
10988
id: EformFieldTypesEnum.ShowPdf,
11089
name: 'ShowPDF',
111-
description: 'Show PDF field',
90+
description: 'Show PDF',
11291
previewImage:
113-
'../../../../../../../assets/images/visual-editor-preview/show-pdf.png',
92+
'../../../../../../../assets/images/visual-editor-preview/show-pdf-screenshot.png',
11493
},
11594
{
11695
id: EformFieldTypesEnum.FieldGroup,
11796
name: 'FieldGroup',
118-
description: 'Field group / container',
97+
description: 'Field group',
11998
previewImage:
120-
'../../../../../../../assets/images/visual-editor-preview/field-group.png',
99+
'../../../../../../../assets/images/visual-editor-preview/group.png',
100+
},
101+
{
102+
id: EformFieldTypesEnum.NumberStepper,
103+
name: 'NumberStepper',
104+
description: 'Number stepper field',
105+
previewImage: '',
121106
},
122107
{
123108
id: EformFieldTypesEnum.Signature,
124109
name: 'Signature',
125-
description: 'Signature field',
110+
description: 'Simple signature field',
126111
previewImage:
127112
'../../../../../../../assets/images/visual-editor-preview/signature.png',
128113
},
114+
{
115+
id: EformFieldTypesEnum.Timer,
116+
name: 'Timer',
117+
description: 'Simple timer field',
118+
previewImage:
119+
'../../../../../../../assets/images/visual-editor-preview/timer-screenshot.png',
120+
},
129121
{
130122
id: EformFieldTypesEnum.EntitySearch,
131123
name: 'EntitySearch',
132-
description: 'Searchable entity field',
124+
description: 'Autofilled searchable items field',
133125
previewImage:
134126
'../../../../../../../assets/images/visual-editor-preview/entity-search.png',
135127
},
136128
{
137129
id: EformFieldTypesEnum.EntitySelect,
138130
name: 'EntitySelect',
139-
description: 'Selectable entity field',
131+
description: 'Autofilled single selection list',
140132
previewImage:
141133
'../../../../../../../assets/images/visual-editor-preview/entity-select.png',
142134
},
143135
{
144-
id: EformFieldTypesEnum.ShowPicture,
145-
name: 'ShowPicture',
146-
description: 'Show picture field',
147-
previewImage: '',
136+
id: EformFieldTypesEnum.Text,
137+
name: 'Text (TextSingleLine)',
138+
description: 'Simple text field',
139+
previewImage:
140+
'../../../../../../../assets/images/visual-editor-preview/text.png',
148141
},
149142
{
150143
id: EformFieldTypesEnum.Audio,
151144
name: 'Audio',
152-
description: 'Audio field',
153-
previewImage: '',
145+
description: 'Simple audio field',
146+
previewImage:
147+
'../../../../../../../assets/images/visual-editor-preview/audio-screenshot.png',
154148
},
155149
{
156150
id: EformFieldTypesEnum.Movie,
157151
name: 'Movie',
158-
description: 'Movie field',
159-
previewImage: '',
152+
description: 'Simple movie field',
153+
previewImage:
154+
'',
160155
},
161156
{
162-
id: EformFieldTypesEnum.NumberStepper,
163-
name: 'NumberStepper',
164-
description: 'Number stepper field',
157+
id: EformFieldTypesEnum.MultiSelect,
158+
name: 'MultiSelect',
159+
description: 'Simple multi select list',
165160
previewImage:
166-
'../../../../../../../assets/images/visual-editor-preview/number-stepper.png',
161+
'../../../../../../../assets/images/visual-editor-preview/multi-select.png',
162+
},
163+
{
164+
id: EformFieldTypesEnum.ShowPicture,
165+
name: 'Show picture',
166+
description: 'Show a single picture field',
167+
previewImage:
168+
'',
167169
},
168170
];
169171

170172
export const eformVisualEditorElementColors: CommonDictionaryModel[] = [
171-
{ id: 0, name: 'e8eaf6', description: 'Standard' },
172-
{ id: 1, name: 'c8e6c9', description: 'Green' },
173-
{ id: 2, name: 'bbdefb', description: 'Blue' },
174-
{ id: 3, name: 'fff9c4', description: 'Yellow' },
175-
{ id: 4, name: 'ffccbc', description: 'Red' },
176-
{ id: 5, name: 'f5f5f5', description: 'Grey' },
173+
{
174+
id: 1,
175+
description: 'Standard',
176+
name: 'e8eaf6',
177+
},
178+
{
179+
id: 2,
180+
description: 'Green',
181+
name: 'f0f8db',
182+
},
183+
{
184+
id: 3,
185+
description: 'Blue',
186+
name: 'e2f4fb',
187+
},
188+
{
189+
id: 4,
190+
description: 'Yellow',
191+
name: 'fff6df',
192+
},
193+
{
194+
id: 5,
195+
description: 'Red',
196+
name: 'ffe4e4',
197+
},
198+
{
199+
id: 6,
200+
description: 'Grey',
201+
name: 'e7e7e7',
202+
},
177203
];

0 commit comments

Comments
 (0)