fix: replace hardcoded FieldTypeId comparisons with DB lookups

EFormService.cs (template duplication):
- CreateFields() had `if (field.FieldTypeId == 17)` to detect FieldGroup.
  The DB auto-increments FieldType.Id, so 17 is not guaranteed to be
  FieldGroup. Now queries FieldTypes table by Constants.FieldTypes.FieldGroup.
  This was the root cause of corrupted FieldTypeIds when duplicating eforms.

EformCaseReportService.cs (case reports):
- Two places had `x.Field.FieldTypeId == 5` to filter Picture fields.
  Now queries FieldTypes table by Constants.FieldTypes.Picture.

There are additional hardcoded IDs in plugin repos (Workflow, ItemsPlanning,
BackendConfiguration report service) that need the same fix separately.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: renemadsen

eFormAPI/eFormAPI.Web/Services/EFormService.cs

@@ -934,10 +934,13 @@ private static async Task<CheckList> FindTemplates(int idEform, MicrotingDbConte
     private static async Task CreateFields(int eformId, MicrotingDbContext sdkDbContext,
         List<Microting.eForm.Infrastructure.Data.Entities.Field> fieldsList)
     {
+        var fieldGroupTypeId = (await sdkDbContext.FieldTypes
+            .FirstAsync(ft => ft.Type == Microting.eForm.Infrastructure.Constants.Constants.FieldTypes.FieldGroup)).Id;
+
         foreach (var field in fieldsList)
         {
             field.CheckListId = eformId;
-            if (field.FieldTypeId == 17) // field group
+            if (field.FieldTypeId == fieldGroupTypeId)
             {
                 foreach (var fieldChild in field.Children)
                 {

eFormAPI/eFormAPI.Web/Services/EformCaseReportService.cs

@@ -152,9 +152,12 @@ public async Task<OperationDataResult<EFormCasesReportModel>> GetReportEformCase
             }
         }
 
+        var pictureFieldTypeId = (await sdkDbContext.FieldTypes
+            .FirstAsync(ft => ft.Type == Constants.FieldTypes.Picture)).Id;
+
         var imagesForEform = await sdkDbContext.FieldValues
             .Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
-            .Where(x => x.Field.FieldTypeId == 5)
+            .Where(x => x.Field.FieldTypeId == pictureFieldTypeId)
             .Where(x => casesIds.Contains((int) x.CaseId))
             .OrderBy(x => x.CaseId)
             .ToListAsync();
@@ -290,7 +293,7 @@ await sdkDbContext.FieldOptionTranslations.SingleAsync(x =>
 
             reportEformCaseModel.ImagesCount = await sdkDbContext.FieldValues
                 .Where(x => x.WorkflowState != Constants.WorkflowStates.Removed)
-                .Where(x => x.Field.FieldTypeId == 5)
+                .Where(x => x.Field.FieldTypeId == pictureFieldTypeId)
                 .Where(x => x.CaseId == caseDto.Id)
                 .Select(x => x.Id)
                 .CountAsync();