Fix subscription management to prevent memory leaks

Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>

Author: Copilot

eform-client/src/app/plugins/modules/time-planning-pn/modules/absence-requests/components/absence-requests-actions/absence-requests-approve-modal/absence-requests-approve-modal.component.ts

@@ -6,6 +6,7 @@ import { ToastrService } from 'ngx-toastr';
 import { TranslateService } from '@ngx-translate/core';
 import { Store } from '@ngrx/store';
 import { selectCurrentUserId } from 'src/app/state';
+import { take } from 'rxjs';
 
 @Component({
   selector: 'app-absence-requests-approve-modal',
@@ -24,13 +25,12 @@ export class AbsenceRequestsApproveModalComponent implements OnInit {
 
   selectedAbsenceRequest: AbsenceRequestModel;
   decisionComment: string = '';
-  currentUserId: number = null;
-  public selectCurrentUserId$ = this.store.select(selectCurrentUserId);
+  currentUserId: number | null = null;
 
   ngOnInit() {
     this.selectedAbsenceRequest = { ...this.model.selectedAbsenceRequest };
-    // Get current user ID
-    this.selectCurrentUserId$.subscribe((userId) => {
+    // Get current user ID (take only once)
+    this.store.select(selectCurrentUserId).pipe(take(1)).subscribe((userId) => {
       this.currentUserId = userId;
     });
   }

eform-client/src/app/plugins/modules/time-planning-pn/modules/absence-requests/components/absence-requests-actions/absence-requests-reject-modal/absence-requests-reject-modal.component.ts

@@ -6,6 +6,7 @@ import { ToastrService } from 'ngx-toastr';
 import { TranslateService } from '@ngx-translate/core';
 import { Store } from '@ngrx/store';
 import { selectCurrentUserId } from 'src/app/state';
+import { take } from 'rxjs';
 
 @Component({
   selector: 'app-absence-requests-reject-modal',
@@ -24,13 +25,12 @@ export class AbsenceRequestsRejectModalComponent implements OnInit {
 
   selectedAbsenceRequest: AbsenceRequestModel;
   decisionComment: string = '';
-  currentUserId: number = null;
-  public selectCurrentUserId$ = this.store.select(selectCurrentUserId);
+  currentUserId: number | null = null;
 
   ngOnInit() {
     this.selectedAbsenceRequest = { ...this.model.selectedAbsenceRequest };
-    // Get current user ID
-    this.selectCurrentUserId$.subscribe((userId) => {
+    // Get current user ID (take only once)
+    this.store.select(selectCurrentUserId).pipe(take(1)).subscribe((userId) => {
       this.currentUserId = userId;
     });
   }

eform-client/src/app/plugins/modules/time-planning-pn/modules/absence-requests/components/absence-requests-container/absence-requests-container.component.ts

@@ -1,7 +1,7 @@
 import { Component, OnInit, OnDestroy, inject } from '@angular/core';
 import { TimePlanningPnAbsenceRequestsService } from '../../../../services';
 import { AbsenceRequestModel } from '../../../../models';
-import { Subscription } from 'rxjs';
+import { Subscription, take } from 'rxjs';
 import { MatDialog } from '@angular/material/dialog';
 import { Overlay } from '@angular/cdk/overlay';
 import { AutoUnsubscribe } from 'ngx-auto-unsubscribe';
@@ -27,12 +27,12 @@ export class AbsenceRequestsContainerComponent implements OnInit, OnDestroy {
   absenceRequests: AbsenceRequestModel[] = [];
   getAbsenceRequests$: Subscription;
   currentView: 'inbox' | 'mine' = 'inbox';
-  currentUserId: number = null;
-  public selectCurrentUserId$ = this.store.select(selectCurrentUserId);
+  currentUserId: number | null = null;
+  selectCurrentUserIdSub$: Subscription;
 
   ngOnInit(): void {
     // Subscribe to current user ID
-    this.selectCurrentUserId$.subscribe((userId) => {
+    this.selectCurrentUserIdSub$ = this.store.select(selectCurrentUserId).subscribe((userId) => {
       this.currentUserId = userId;
       if (this.currentUserId) {
         this.loadAbsenceRequests();