Skip to content

Commit 0800aac

Browse files
renemadsenclaude
andcommitted
fix(playwright): enable shifts 3-5 in 1m variant post-migration
Through the 9-PR UseOneMinuteIntervals rollout (b1m..j1m) we discovered that flipping `AssignedSites.UseOneMinuteIntervals = 1` on its own is not sufficient to render shifts 3-5 in the workday-entity-dialog. The dialog gates shift 3, 4 and 5 inputs behind separate per-site `ThirdShiftActive`, `FourthShiftActive` and `FifthShiftActive` boolean columns (added by the base-package migration `20250226060341_Adding3MoreShifts`). Without these flags, variants whose specs need to fill all 5 shifts (e.g. multishift round-trip clones in the b shard) cannot exercise shifts 3-5 at all, which forces the specs to be downgraded or skipped. Extend each shard's `post-migration.sql` (b1m, c1m, d1m, e1m, f1m, h1m, i1m, j1m) to flip these three flags on alongside `UseOneMinuteIntervals` on every active assigned site, so 1m variant specs can fill the full 5-shift form without UI gating. Notes: - The non-1m b shard has no `post-migration.sql` and no `420_*.sql` seed in this directory, so its flag-off behavior is untouched. - The c1m/h1m/i1m header comments still reference "f1m"/"b1m" from the original copy-paste; those are pre-existing and out of scope here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent a0c666a commit 0800aac

8 files changed

Lines changed: 48 additions & 8 deletions

File tree

eform-client/playwright/e2e/plugins/time-planning-pn/b1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/c1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/d1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/e1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/f1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/h1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/i1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

eform-client/playwright/e2e/plugins/time-planning-pn/j1m/post-migration.sql

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,9 @@
1010
-- shard exercises the flag-on rendering / form / picker code paths. The
1111
-- workflow runs this AFTER `Wait for app` (which gates on migrations being
1212
-- complete) and BEFORE the matrix Playwright invocation.
13-
UPDATE AssignedSites SET UseOneMinuteIntervals = 1 WHERE WorkflowState = 'created';
13+
UPDATE AssignedSites
14+
SET UseOneMinuteIntervals = 1,
15+
ThirdShiftActive = 1,
16+
FourthShiftActive = 1,
17+
FifthShiftActive = 1
18+
WHERE WorkflowState = 'created';

0 commit comments

Comments
 (0)