fix: address Copilot review - singleton fetch + backend delete guard

- Fetch all pay rule set names (pageSize: 10000) before opening create
  modal to ensure singleton filtering works beyond page 1
- Add server-side delete guard with LockedPresetNames HashSet in
  PayRuleSetService.Delete - returns failure for locked presets

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: renemadsen

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/PayRuleSetService/PayRuleSetService.cs

@@ -22,6 +22,29 @@ namespace TimePlanning.Pn.Services.PayRuleSetService;
 
 public class PayRuleSetService : IPayRuleSetService
 {
+    private static readonly HashSet<string> LockedPresetNames = new HashSet<string>
+    {
+        "GLS-A / 3F - Jordbrug Standard",
+        "GLS-A / 3F - Jordbrug Dyrehold",
+        "GLS-A / 3F - Jordbrug Elev u18",
+        "GLS-A / 3F - Jordbrug Elev o18",
+        "GLS-A / 3F - Jordbrug Elev u18 Dyrehold",
+        "GLS-A / 3F - Gartneri Standard",
+        "GLS-A / 3F - Gartneri Elev u18",
+        "GLS-A / 3F - Gartneri Elev o18",
+        "GLS-A / 3F - Skovbrug Standard",
+        "GLS-A / 3F - Skovbrug Elev u18",
+        "GLS-A / 3F - Skovbrug Elev o18",
+        "KA / Krifa - Landbrug Svine/Kvaeg Standard",
+        "KA / Krifa - Landbrug Svine/Kvaeg Elev",
+        "KA / Krifa - Landbrug Plantebrug Standard",
+        "KA / Krifa - Landbrug Plantebrug Elev",
+        "KA / Krifa - Landbrug Maskinstation Standard",
+        "KA / Krifa - Landbrug Maskinstation Elev",
+        "KA / Krifa - Gron Standard",
+        "KA / Krifa - Gron Elev"
+    };
+
     private readonly TimePlanningPnDbContext _dbContext;
     private readonly ILogger<PayRuleSetService> _logger;
 
@@ -549,6 +572,11 @@ public async Task<OperationResult> Delete(int id)
                 return new OperationResult(false, "Pay rule set not found");
             }
 
+            if (LockedPresetNames.Contains(payRuleSet.Name))
+            {
+                return new OperationResult(false, "Cannot delete - this overenskomst is a locked preset and cannot be removed");
+            }
+
             await payRuleSet.Delete(_dbContext);
 
             return new OperationResult(true, "Pay rule set deleted successfully");

eform-client/src/app/plugins/modules/time-planning-pn/modules/pay-rule-sets/components/pay-rule-sets-container/pay-rule-sets-container.component.ts

@@ -52,18 +52,27 @@ export class PayRuleSetsContainerComponent implements OnInit, OnDestroy {
   }
 
   onCreateClicked(): void {
-    const dialogRef = this.dialog.open(PayRuleSetsCreateModalComponent, {
-      minWidth: 1280,
-      maxWidth: 1440,
-      data: { existingNames: this.payRuleSets.map(p => p.name) },
-    });
+    // Fetch all pay rule set names (not just the current page) for singleton filtering
+    this.payRuleSetsService
+      .getPayRuleSets({ offset: 0, pageSize: 10000 })
+      .subscribe((allData) => {
+        const allNames = allData && allData.success
+          ? allData.model.payRuleSets.map(p => p.name)
+          : this.payRuleSets.map(p => p.name);
 
-    dialogRef.afterClosed().subscribe((result) => {
-      if (result) {
-        // Refresh the table after successful create
-        this.getPayRuleSets();
-      }
-    });
+        const dialogRef = this.dialog.open(PayRuleSetsCreateModalComponent, {
+          minWidth: 1280,
+          maxWidth: 1440,
+          data: { existingNames: allNames },
+        });
+
+        dialogRef.afterClosed().subscribe((result) => {
+          if (result) {
+            // Refresh the table after successful create
+            this.getPayRuleSets();
+          }
+        });
+      });
   }
 
   onEditClicked(payRuleSet: PayRuleSetSimpleModel): void {