Skip to content

Commit 95f802c

Browse files
renemadsenclaude
andcommitted
fix: correct parameter order (start,stop,pause) and avoid hour 0 in break
The function signature was (start,pause,stop) but calls passed (start,stop,pause). Fixed signature to match callers. Also replaced all 00:30 breaks with 01:00 to avoid hour 0 which needs the inner clock ring (height:85px + rotateZ:720deg) that may not exist on the planned shift timepicker. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 900a072 commit 95f802c

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

eform-client/playwright/e2e/plugins/time-planning-pn/c/time-planning-glsa-3f-pay-rules.spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,10 @@ async function setPlannedShiftTimes(
226226
page: Page,
227227
shiftId: number,
228228
start: string,
229-
pause: string,
230229
stop: string,
230+
pause: string,
231231
): Promise<void> {
232-
// Order matters: break is disabled until start+stop are set
232+
// Order: start → stop → break (break is disabled until start+stop are set)
233233
await setTimepickerValue(page, `plannedStartOfShift${shiftId}`, start);
234234
await setTimepickerValue(page, `plannedEndOfShift${shiftId}`, stop);
235235
await setTimepickerValue(page, `plannedBreakOfShift${shiftId}`, pause);
@@ -361,31 +361,31 @@ test.describe('GLS-A / 3F Pay Rule Set Full Pipeline E2E', () => {
361361
// ---- Step 4: Enter planned shift times for Monday (day index 0) ----
362362
// Use AM hours only (1-12) to stay on the outer clock ring
363363
await openWorkdayDialog(page, 0, 0);
364-
await setPlannedShiftTimes(page, 1, '06:00', '12:00', '00:30');
364+
await setPlannedShiftTimes(page, 1, '06:00', '12:00', '01:00');
365365
await setPlanHours(page, 6);
366366
await saveWorkdayDialog(page);
367367

368368
// ---- Step 5: Tuesday (day index 1) ----
369369
await openWorkdayDialog(page, 0, 1);
370-
await setPlannedShiftTimes(page, 1, '06:00', '12:00', '00:30');
370+
await setPlannedShiftTimes(page, 1, '06:00', '12:00', '01:00');
371371
await setPlanHours(page, 6);
372372
await saveWorkdayDialog(page);
373373

374374
// ---- Step 6: Wednesday (day index 2) ----
375375
await openWorkdayDialog(page, 0, 2);
376-
await setPlannedShiftTimes(page, 1, '07:00', '12:00', '00:30');
376+
await setPlannedShiftTimes(page, 1, '07:00', '12:00', '01:00');
377377
await setPlanHours(page, 5);
378378
await saveWorkdayDialog(page);
379379

380380
// ---- Step 7: Thursday (day index 3) ----
381381
await openWorkdayDialog(page, 0, 3);
382-
await setPlannedShiftTimes(page, 1, '06:00', '12:00', '00:30');
382+
await setPlannedShiftTimes(page, 1, '06:00', '12:00', '01:00');
383383
await setPlanHours(page, 6);
384384
await saveWorkdayDialog(page);
385385

386386
// ---- Step 8: Friday (day index 4) ----
387387
await openWorkdayDialog(page, 0, 4);
388-
await setPlannedShiftTimes(page, 1, '07:00', '12:00', '00:30');
388+
await setPlannedShiftTimes(page, 1, '07:00', '12:00', '01:00');
389389
await setPlanHours(page, 5);
390390
await saveWorkdayDialog(page);
391391

0 commit comments

Comments
 (0)