Skip to content

Commit cf76e7c

Browse files
renemadsenclaude
andcommitted
fix(playwright): drop obsolete useGoogleSheetAsDefault toggle in (c)
The ensure-on block for #useGoogleSheetAsDefault hung the (c) suite for the full 120s timeout. Two business-logic changes made it unreachable: - e86d3a1 seeds useGoogleSheetAsDefault=true for every assigned site on install, so no flip is needed. - c7732b4 gates the checkbox behind selectCurrentUserIsFirstUser$ in assigned-site-dialog.component.html:9, so the element never renders for the admin CI user. The subsequent autoBreakCalculationActive block is admin-gated and still valid, so the test's actual intent ("should enable auto break calculations with empty values") survives. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7b018ee commit cf76e7c

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

eform-client/playwright/e2e/plugins/time-planning-pn/c/dashboard-edit-a.spec.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -276,10 +276,9 @@ test.describe('Dashboard edit values', () => {
276276

277277
await page.locator('#firstColumn0').click();
278278

279-
const useGoogleSheetClass = await page.locator('#useGoogleSheetAsDefault > div > div > input').getAttribute('class');
280-
if (useGoogleSheetClass !== 'mdc-checkbox__native-control mdc-checkbox--selected') {
281-
await page.locator('#useGoogleSheetAsDefault').click();
282-
}
279+
// useGoogleSheetAsDefault is seeded true by default (commit e86d3a1b) and
280+
// its toggle is now first-user-only (commit c7732b40), so the prior
281+
// ensure-on block was unreachable for the admin CI user and timed out.
283282

284283
const autoBreakClass = await page.locator('#autoBreakCalculationActive > div > div > input').getAttribute('class');
285284
if (autoBreakClass !== 'mdc-checkbox__native-control mdc-checkbox--selected') {

0 commit comments

Comments
 (0)