fix(timeplanning): admin exact-minute actual start/stop under UseOneMinuteIntervals=true (#1572)

* fix(timeplanning): admin exact-minute actual start/stop under UseOneMinuteIntervals=true (#TBD)

- Adds Start{1..5}ExactMinutes / Stop{1..5}ExactMinutes DTO fields mirroring PR #1568's pause shape
- Math.round in convertTimeToMinutes to kill the 37.6 float that produced the admin-edit error
- ApplyExactMinuteStart/Stop helpers write Start*StartedAt/Stop*StoppedAt under flag-on; cross-midnight aware
- DeriveLegacyShiftIdsFromTimestamps keeps legacy *Id columns in sync after timestamp writes (admin + worker paths)
- ComputePlanningNettoMinutes routes netto math through timestamps under flag-on (was 5-min-quantized via *Id)
- New l1m Playwright shard with 6 round-trip regression tests + 1 flag-off regression test in f shard
- CI matrix bumped to include all playwright shards on disk

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(timeplanning): fix new l1m playwright tests after first CI run

- Drop cross-midnight 23:55->00:30 test: dialog requires stop>start within a shift, so the case is backend-only (ApplyExactMinuteStop handles it for worker-persisted timestamps but admin can't enter it through the UI)
- Bump 5-shifts test timeout to 300s: 12 timepicker fills × ~7s each exceeds default 120s

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(timeplanning): revert Math.round in convertTimeToMinutes; isolate l1m netto test

- f1m midnight tests rely on float-value cancellation: (29.8-1)*5 = 144. Math.round broke this. The float-on-wire concern is moot since ASP.NET silently truncates and the new Start*ExactMinutes path writes the precise timestamp regardless.
- l1m netto test was reading leftover pause from prior 5-shift test in same cell; isolated by using a different cell.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(timeplanning): restore Math.round at wire + route calculatePlanHours via *ExactMinutes under flag-on

- Math.round in convertTimeToMinutes is required: float 37.6 → ASP.NET int? deserializer rejects with 400 → silent save failure (the original user-reported "error")
- f1m display tests were collateral damage from the prior Math.round revert: their flex math depends on float cancellation of (stop_float-1)*5=exact_minutes
- New approach under flag-on: calculatePlanHours derives actualMinutes from picker strings directly (toRawMinutes) instead of *Id, so display is exact-minute regardless of Math.round at the wire
- Flag-off path unchanged: still uses legacy *Id math (picker minutesGap=5 ensures integer values)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(timeplanning): isolate l1m netto test from prior pause-timestamp residue

The 5-shift test persists Pause1StartedAt/StoppedAt timestamps on cell0_0
(pause='00:02'); the netto-check test then reused the same cell and the
backend's ComputePlanningNettoMinutes still saw those 2 min of leftover
pause -> netto = 488 min ('8.13') vs the expected 490 min ('8.17').

A prior fix clicked the dialog's pause-delete icon, which only patches the
form pause to null. Under UseOneMinuteIntervals=true that sends
pause1ExactMinutes = null, and the backend's `if (minutes.HasValue)
ApplyExactMinutePause` guard skips ClearPauseTimestamps entirely - so the
timestamps survived.

Fix: explicitly pick pause='00:00' via the timepicker (after start/stop so
the picker's [max]=getMaxDifference resolves to a positive duration). That
sends pause1ExactMinutes = 0, which ApplyExactMinutePause routes through
ClearPauseTimestamps to null Pause1StartedAt/StoppedAt on save.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: renemadsen

.github/workflows/dotnet-core-master.yml

@@ -88,7 +88,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        test: [a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,b1m,c1m,d1m,e1m,f1m,h1m,i1m,j1m]
+        test: [a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,b1m,c1m,d1m,e1m,f1m,h1m,i1m,j1m,l1m]
     steps:
     - uses: actions/checkout@v3
       with:

.github/workflows/dotnet-core-pr.yml

@@ -81,7 +81,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        test: [a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,b1m,c1m,d1m,e1m,f1m,h1m,i1m,j1m]
+        test: [a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,b1m,c1m,d1m,e1m,f1m,h1m,i1m,j1m,l1m]
     steps:
     - uses: actions/checkout@v3
       with:

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Infrastructure/Models/Planning/TimePlanningPlanningPrDayModel.cs

@@ -107,6 +107,22 @@ public class TimePlanningPlanningPrDayModel
     public int? Pause4ExactMinutes { get; set; }
     public int? Pause5ExactMinutes { get; set; }
 
+    // Request-only: exact-minute start/stop times under UseOneMinuteIntervals=true.
+    // Null means the client did not send the new field; backend falls back to the
+    // legacy Start*Id/Stop*Id (5-minute slot) write path. When set, backend
+    // translates the minutes-of-day into Start*StartedAt/Stop*StoppedAt timestamps
+    // (anchor: planning.Date; cross-midnight on Stop when value <= matching Start).
+    public int? Start1ExactMinutes { get; set; }
+    public int? Start2ExactMinutes { get; set; }
+    public int? Start3ExactMinutes { get; set; }
+    public int? Start4ExactMinutes { get; set; }
+    public int? Start5ExactMinutes { get; set; }
+    public int? Stop1ExactMinutes { get; set; }
+    public int? Stop2ExactMinutes { get; set; }
+    public int? Stop3ExactMinutes { get; set; }
+    public int? Stop4ExactMinutes { get; set; }
+    public int? Stop5ExactMinutes { get; set; }
+
     public int Break1Shift { get; set; }
     public int Break2Shift { get; set; }
     public int Break3Shift { get; set; }

eFormAPI/Plugins/TimePlanning.Pn/TimePlanning.Pn/Services/TimePlanningPlanningService/TimePlanningPlanningService.cs

@@ -166,4 +166,56 @@ test.describe('Dashboard edit values', () => {
     await expect(page.locator('#planHours')).toHaveValue('22');
     await expect(page.locator('#todaysFlex')).toHaveValue('0.00');
   });
+
+  /**
+   * Flag-off regression guard for the admin-edit exact-minute work:
+   * setting a clean 5-min-aligned actual pair (`03:00 → 11:00`) on a
+   * flag-off worker must still save and reload correctly. The additive
+   * `Start{N}ExactMinutes` / `Stop{N}ExactMinutes` DTO fields plus the
+   * server-side `ApplyExactMinuteStart/Stop` helpers were introduced
+   * for the flag-on path — this test locks the contract that the
+   * flag-off path is bit-identical to before (i.e. our `Math.round`
+   * change and the additive DTO fields did NOT alter flag-off
+   * behavior). A regression in either direction (e.g. ExactMinutes
+   * leaking into the flag-off save path or the DTO change altering
+   * serialization defaults) would surface here as a `toHaveValue`
+   * mismatch or a save-button-disabled stall.
+   *
+   * 03:00 → 11:00 = 480 min ⇒ start1Id = (180/5)+1 = 37; stop1Id =
+   * (660/5)+1 = 133; (133-37)*5 = 480 min ⇒ actualHours = 8.00.
+   */
+  test('flag-off: clean 5-min actual pair 03:00 -> 11:00 round-trips through save + reopen', async ({ page }) => {
+    await setTimepickerValue(page, 'plannedStartOfShift1', '03', '00');
+    await setTimepickerValue(page, 'plannedEndOfShift1', '11', '00');
+    await setTimepickerValue(page, 'start1StartedAt', '03', '00');
+    await setTimepickerValue(page, 'stop1StoppedAt', '11', '00');
+
+    await expect(page.locator('#saveButton')).toBeEnabled({ timeout: 10000 });
+    const updatePromise = page.waitForResponse(r =>
+      r.url().includes('/api/time-planning-pn/plannings/') && r.request().method() === 'PUT');
+    const reindexPromise = page.waitForResponse(r =>
+      r.url().includes('/api/time-planning-pn/plannings/index') && r.request().method() === 'POST');
+    await page.locator('#saveButton').click();
+    const updateResponse = await updatePromise;
+    await reindexPromise;
+    if (await page.locator('.overlay-spinner').count() > 0) {
+      await page.locator('.overlay-spinner').waitFor({ state: 'hidden', timeout: 30000 });
+    }
+    await page.waitForTimeout(500);
+    expect(updateResponse.status(), 'flag-off PUT must succeed with clean 5-min actuals').toBeLessThan(400);
+
+    // Re-open the cell and assert the picker shows the saved clean values.
+    await page.locator('#cell0_0').scrollIntoViewIfNeeded();
+    await page.locator('#cell0_0').click();
+    await expect(page.locator('#planHours')).toBeVisible();
+    await expect(
+      page.locator('[data-testid="start1StartedAt"]'),
+      'flag-off shift1 start must round-trip 03:00 unchanged',
+    ).toHaveValue('03:00');
+    await expect(
+      page.locator('[data-testid="stop1StoppedAt"]'),
+      'flag-off shift1 stop must round-trip 11:00 unchanged',
+    ).toHaveValue('11:00');
+    await page.locator('#cancelButton').click();
+  });
 });