Fix broken unit tests by adding NO_ERRORS_SCHEMA and TranslateModule to component test specs#1078
Conversation
…ilation errors Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
|
@copilot we still have these errors: FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/assigned-site/assigned-site-dialog.component.spec.ts (30.562 s) |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Fixed in commit. |
|
@copilot now we have these left: Failed to collect coverage from /home/runner/work/eform-angular-timeplanning-plugin/eform-angular-timeplanning-plugin/eform-angular-frontend/eform-client/src/app/plugins/modules/time-planning-pn/store-providers.config.ts |
…xports Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Fixed in commit. Removed unused |
|
@copilot these two still fails, so fix those, so they pass too. FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts (7.516 s) FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/workday-entity/workday-entity-dialog.component.spec.ts |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
... Fixed in commit. Added |
|
@copilot we have these errors: Run cd eform-angular-frontend/eform-client
FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts (7.661 s) |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Fixed in commit. Updated test expectation for |
|
@copilot then we have this error: FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/workday-entity/workday-entity-dialog.component.spec.ts (31.356 s) |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Fixed in commit. The test was setting |
|
@copilot we have this error to fix also: FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts (7.359 s) |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Fixed in commit. Added mock for |
|
@copilot now we only have this one left: FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts (7.608 s) |
… tests Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
... Fixed in commit. Mocked |
|
@copilot then there is this error, is it proper jest test or some leftover karma/jasmin style test: FAIL src/app/plugins/modules/time-planning-pn/components/plannings/time-planning-actions/download-excel/download-excel-dialog.component.spec.ts (7.434 s) ● DownloadExcelDialogComponent › Excel Report All Workers Download › should show error toast when download all workers fails |
…proper override Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
The tests are proper Jest style (using |
Fixed Issues:
Test Style: All tests use proper Jest syntax (describe/it/expect/jest.fn). No Karma/Jasmine remnants.
Note: Console.error for invalid dates in isInOlderThanToday is intentional error logging, not a test failure.
Fixes #1077
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.