Phase 5 PR 3: d1m playwright variant — UseOneMinuteIntervals=true#1549
Merged
Merged
Conversation
…er-ring 13-23 Third PR in the 9-PR Phase-5 sequence. Mirrors b1m / c1m: own seed copy, post-migration patch flipping `UseOneMinuteIntervals = 1` on every active assigned site, and a single multi-shift (3-5) round-trip spec at off-grid times. The d1m neighborhood targets the inner-ring 13-23 hour positions of the timepicker clock face. b1m sweeps outer ring 1-10 (early morning), c1m straddles the outer→inner transition (08:xx → 19:xx); d1m keeps every shift entirely inside the inner ring so the variant matrix as a whole exercises the full 24-hour surface at 1-minute granularity. Per the brainstorm map, the d shard's source spec (`d/dashboard-edit-a.spec.ts`) is NOT directly cloned — its two tests only fill shift 1, the partial-shift shape that hits the still-unresolved `success:false` path inside `TimePlanningPlanningService.Update` (see PR #1545 / PR #1548 lessons). d1m therefore ships the same multishift shape as b1m/c1m with a fresh time block, keeping the variant useful for the flag-on code path without reproducing the deferred Update bug. Workflow `matrix.test:` updated in both `dotnet-core-master.yml` and `dotnet-core-pr.yml`. The generic post-migration step on stable picks up `d1m/post-migration.sql` automatically — no workflow logic changes needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Phase-5 Playwright shard variant (d1m) to exercise the UseOneMinuteIntervals = true path using off-grid, inner-ring (13–23) timepicker selections, and wires it into CI shard matrices.
Changes:
- Add
OFFGRID_TIMES_D1Mto the shared Playwright time-literals helper. - Introduce the new
d1mshard folder (seed copies, post-migration SQL patch, and a multi-shift round-trip spec). - Extend both PR and master CI workflow Playwright matrices to run the
d1mshard.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eform-client/playwright/helpers/one-minute-times.ts | Adds OFFGRID_TIMES_D1M constants for inner-ring off-grid times. |
| eform-client/playwright/e2e/plugins/time-planning-pn/d1m/post-migration.sql | Enables UseOneMinuteIntervals for active assigned sites for the d1m shard via the existing post-migration mechanism. |
| eform-client/playwright/e2e/plugins/time-planning-pn/d1m/dashboard-edit-multishift.spec.ts | New multi-shift (1–5) save+reload round-trip spec using inner-ring off-grid times. |
| .github/workflows/dotnet-core-pr.yml | Adds d1m to the Playwright matrix for PR runs. |
| .github/workflows/dotnet-core-master.yml | Adds d1m to the Playwright matrix for push runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+46
to
+50
| async function pickTime(page: Page, timeStr: string) { | ||
| // Position-based clock-face clicks. Works uniformly for h=0 (break | ||
| // times), unlike rotateZ-selector strategies. Identical helper to b1m/c1m. | ||
| const [hourStr, minuteStr] = timeStr.split(':'); | ||
| const h = parseInt(hourStr, 10); |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third PR in the 9-PR Phase-5 sequence. Adds the
d1mshard variantexercising
UseOneMinuteIntervals = trueat off-grid clock-face minutesinside the inner-ring 13-23 hour positions. Mirrors PR #1545 (b1m, outer
ring 1-10) and PR #1548 (c1m, outer→inner 08:xx-19:xx) — same shape, new
neighborhood.
d1m/(identical toc1m//a/).d1m/post-migration.sqlflipsUseOneMinuteIntervals = 1on everyactive assigned site (picked up by the generic post-migration workflow
step that already lives on stable).
spanning 13:02 - 23:39, all on the inner ring, mirroring b1m/c1m.
matrix.test:updated in bothdotnet-core-master.ymlanddotnet-core-pr.ymlto included1m.OFFGRID_TIMES_D1Mconstants added toeform-client/playwright/helpers/one-minute-times.ts.Why not clone
d/dashboard-edit-a.spec.tsdirectly?That source spec only fills shift 1 — the partial-shift shape that hits
the still-unresolved
success:falsepath insideTimePlanningPlanningService.Update(see PR #1545 + PR #1548 lessons).d1m therefore ships the same multishift-shape clone as b1m/c1m with a
fresh time neighborhood, keeping the variant entry useful for the
flag-on code path without reproducing the deferred Update bug.
Test plan
d1mmatrix shard goes green on CI.a-pshards or onb1m/c1m.🤖 Generated with Claude Code