fix(calendar): render now-line in front of task tiles#992
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adjusts calendar styling so the “now” indicator (red current-time line) renders above task tiles in both week and day views, matching the reported UX requirement in the plugin’s Angular calendar module.
Changes:
- Increased
.now-linestacking order to ensure it paints in front of task tiles (including “raised” tiles). - Applied the same z-index adjustment consistently in both week-grid and day-column implementations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-week-grid/calendar-week-grid.component.scss | Raises .now-line z-index so the current-time line renders above week-view task tiles. |
| eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-day-column/calendar-day-column.component.scss | Mirrors the .now-line z-index change for the day-view column layout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback
"Vis den aktuelle tidslinje i kalender (den røde streg) foran opgaverne og ikke bagved." — show the current-time line in front of the tasks, not behind.
Fix
The
.now-linehadz-index: 10, the same as task tiles (z 10–13, or 999 when raised), so tiles painted over it. Bumped.now-linetoz-index: 1000(above raised tiles) in bothcalendar-week-gridand the parallelcalendar-day-column. It already haspointer-events: none, so it doesn't block clicks/drag on the tiles underneath. No e2e test references the now-line.🤖 Generated with Claude Code