fix(calendar): completed events always use white text

[renemadsen]

Summary

Completed calendar events get a green (#5c7829) background (.completed class), but their text colour still followed the board-colour contrast rule boardTextColor(task.color). That rule returns dark #1a1a1a for the four "light" boards (#fff286 / #e6cfff / #ff88cf / #bfd8ff), producing unreadable dark text on the green tile. Completed events should always be white.

Fix (Option B — emit null inline colour, let base CSS win)

• calendar-task-block.component.html — timed tiles: [style.color] now emits null when task.completed (in addition to the existing inactive guard), so the base .task-block { color: white } (which .task-time inherits) applies.
• calendar-week-grid.component.html — all-day chips: same task.completed ? null : … guard; base .all-day-chip { color: #fff } applies.
• calendar-task-block.component.scss — comment only (no rule change): documents why no explicit colour is needed on .completed (base is already white), unlike .gcal-task--inactive.completed which must re-assert white over the inactive grey.

The text colour is now board-colour-independent for completed events; non-completed events keep the contrast rule unchanged. Mirrors the existing inactive-tile null-emit mechanism.

Verification

Live on /plugins/backend-configuration-pn/calendar: a completed tile has the inline colour removed and computes rgb(255,255,255) white on the green background; simulating the old path (#1a1a1a inline) reproduced the dark-on-green bug. Reviewed by code-reviewer + code-simplifier (no issues; confirmed no regression for the inactive+completed combination, drag-ghost, or schedule view).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes unreadable text on completed calendar events by ensuring completed tiles/chips no longer use the board-dependent contrast color (boardTextColor(...)), allowing the base CSS white text to apply consistently on the green completed background.

Changes:

• Timed event tiles now emit null for [style.color] when task.completed, removing the inline color so .task-block { color: white } wins.
• All-day chips now emit null for [style.color] when task.completed, removing the inline color so .all-day-chip { color: #fff } wins.
• Added an explanatory comment in the timed tile SCSS clarifying why no explicit completed text color rule is required.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-week-grid/calendar-week-grid.component.html	Prevents completed all-day chips from applying board-based inline text color so base white text applies.
eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-task-block/calendar-task-block.component.scss	Documents the completed-text-color rationale and relationship to template inline-style removal.
eform-client/src/app/plugins/modules/backend-configuration-pn/modules/calendar/components/calendar-task-block/calendar-task-block.component.html	Prevents completed timed tiles from applying board-based inline text color so base white text applies.