ci: set ALLOW_FAKE_TRANSLATE=true for translation e2e#999
Merged
Conversation
Prepares for gating the FAKE_TRANSLATE_E2E sentinel behind an explicit opt-in env so it can never fire in production. No-op until the backend code change lands (the env is currently ignored by TranslationService). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin’s GitHub Actions CI workflows to pass an opt-in environment variable (ALLOW_FAKE_TRANSLATE=true) into the Playwright test Docker container, preparing CI for an upcoming backend change that will gate the FAKE_TRANSLATE_E2E sentinel behind this flag.
Changes:
- Add
-e ALLOW_FAKE_TRANSLATE=trueto thedocker runinvocation in the PR workflow Playwright job. - Add
-e ALLOW_FAKE_TRANSLATE=trueto thedocker runinvocation in the master workflow Playwright job.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/dotnet-core-pr.yml | Passes ALLOW_FAKE_TRANSLATE=true into the Playwright-test container during PR CI runs. |
| .github/workflows/dotnet-core-master.yml | Passes ALLOW_FAKE_TRANSLATE=true into the Playwright-test container during master CI runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
ALLOW_FAKE_TRANSLATE=trueopt-in env to the backend-pn playwrightdocker run(both pr + master workflows), ahead of gating theFAKE_TRANSLATE_E2Esentinel inTranslationService.No-op until the backend code change lands — the env is currently ignored. This must merge before the
eform-angular-frontendcode change so shardmkeeps passing once the sentinel requires the flag.See spec
2026-06-11-translation-real-apikey-prod-design.md.🤖 Generated with Claude Code