Skip to content

[oadp-1.6] Only create DataUpload if matching custom volume policy is found#24

Open
sseago wants to merge 5 commits into
migtools:oadp-1.6from
sseago:custom-volume-policy-1.6
Open

[oadp-1.6] Only create DataUpload if matching custom volume policy is found#24
sseago wants to merge 5 commits into
migtools:oadp-1.6from
sseago:custom-volume-policy-1.6

Conversation

@sseago

@sseago sseago commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

This is a cherry-pick of #23

Fixes migtools/kubevirt-datamover-controller#50

Instead of using a "skip" volume policy to indicate a kubevirt-dm backup, use a "custom" policy with the paramater "datamover: kubevirt" set. With this PR, skip will perform no datamover action at all. The matching volume policy for kubevirt-DM is:

      action:
        type: custom
        parameters:
          datamover: kubevirt

@openshift-ci
openshift-ci Bot requested review from Joeavaikath and mpryc June 29, 2026 15:32
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 941fab1b-1e27-4aac-b6cc-0d019f59fc90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kaovilai

kaovilai commented Jul 8, 2026

Copy link
Copy Markdown
Member

Please rebase.

@kaovilai kaovilai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants