fix recreate binding on failure#1516
Merged
miguelgrinberg merged 1 commit intoOct 30, 2025
Merged
Conversation
Owner
|
Looks good, thanks! |
|
when is this going to be released? this is a huge improvement for us apparently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Recreate RabbitMQ bindings on connection failure
Fixes
Closes #1469
Closes #1513
Problem
When RabbitMQ goes down and comes back up, the Socket.IO servers enter a split-brain state where they can send events but never receive them. This occurs because:
This results in servers that appear healthy but silently fail to process incoming events.
Root Cause
When RabbitMQ goes down and comes back up, Socket.IO servers enter a split-brain state where they can send events but never receive them.
Solution
Move the exchange/queue binding creation inside the retry loop so they are recreated on every connection failure.
Result
When RabbitMQ restarts, the exception triggers a retry that creates fresh connection, channel, exchange, and queue objects with valid bindings. Servers can now both send and receive events after recovery.