Added: Enhanceed MangaChapterListItem with focus state and visual fee…#3264
Open
Troppy2 wants to merge 2 commits into
Open
Added: Enhanceed MangaChapterListItem with focus state and visual fee…#3264Troppy2 wants to merge 2 commits into
Troppy2 wants to merge 2 commits into
Conversation
Member
|
run spotless please |
Author
|
Sorry about that, I hope the second commit fixed the formatting issues. I'll remember to run spotless when making new commits. Thank you! |
Member
|
I see you made some visual edit with that drawbehind thing. Do you have some example screenshots? Make sure to censor source names if they're visible. |
Author
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is meant to close issue #3239. The issue was about keyboard compatibility with Mihon and focus highlights.
The exact changes that were added were mostly in MangaChapterListItem.kt, which added a focus highlight (imports + isFocused state + drawBehind + onFocusChanged). I tested it on Android Studio to see if it worked with a keyboard, and I was able to use the arrow + tab keys, but I didn't do extensive testing.
Side Note: This is my first time contributing to this repo, and I have been using this open-source app for a long time, so I wanted to contribute to it. I don't have extensive Kotlin knowledge (mostly Java), so any feedback would be really appreciated.