Skip to content

Added: Enhanceed MangaChapterListItem with focus state and visual fee…#3264

Open
Troppy2 wants to merge 2 commits into
mihonapp:mainfrom
Troppy2:main
Open

Added: Enhanceed MangaChapterListItem with focus state and visual fee…#3264
Troppy2 wants to merge 2 commits into
mihonapp:mainfrom
Troppy2:main

Conversation

@Troppy2
Copy link
Copy Markdown

@Troppy2 Troppy2 commented Apr 25, 2026

This PR is meant to close issue #3239. The issue was about keyboard compatibility with Mihon and focus highlights.

The exact changes that were added were mostly in MangaChapterListItem.kt, which added a focus highlight (imports + isFocused state + drawBehind + onFocusChanged). I tested it on Android Studio to see if it worked with a keyboard, and I was able to use the arrow + tab keys, but I didn't do extensive testing.

Side Note: This is my first time contributing to this repo, and I have been using this open-source app for a long time, so I wanted to contribute to it. I don't have extensive Kotlin knowledge (mostly Java), so any feedback would be really appreciated.

@MajorTanya
Copy link
Copy Markdown
Member

run spotless please
spotlessApply

@Troppy2
Copy link
Copy Markdown
Author

Troppy2 commented Apr 25, 2026

Sorry about that, I hope the second commit fixed the formatting issues. I'll remember to run spotless when making new commits. Thank you!

@MajorTanya
Copy link
Copy Markdown
Member

I see you made some visual edit with that drawbehind thing. Do you have some example screenshots? Make sure to censor source names if they're visible.

@Troppy2
Copy link
Copy Markdown
Author

Troppy2 commented Apr 25, 2026

Yeah I don't think the update I made did much though because I currently use the app and the features the issue was talking about I assumed was already in the app, but I use the mobile version I have no idea other use cases of this app outside of phones, and tablets.

I don't know how to show that I used my keyboard but if you click tab multiple times, it can scroll down and select chapters it highlights the chapter that is selected.

Screenshot_20260424_215606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants