Use start returned from _attemptOperation in extend() (#276)

arath17 · Ashutosh Rath · web-flow · commit 51388139356e · 2023-06-07T16:56:21.000-07:00
* Fix extension failure

* format

* Use start returned from _attemptOperation in extend() for calculating expiration time

---------

Co-authored-by: Ashutosh Rath &lt;arath9@its.jnj.com&gt;
diff --git a/src/index.ts b/src/index.ts
@@ -375,14 +375,12 @@ export default class Redlock extends EventEmitter {
       throw new Error("Duration must be an integer value in milliseconds.");
     }
 
-    const start = Date.now();
-
     // The lock has already expired.
     if (existing.expiration < Date.now()) {
       throw new ExecutionError("Cannot extend an already-expired lock.", []);
     }
 
-    const { attempts } = await this._execute(
+    const { attempts, start } = await this._execute(
       this.scripts.extendScript,
       existing.resources,
       [existing.value, duration],

Original file line number	Diff line number	Diff line change
`@@ -375,14 +375,12 @@ export default class Redlock extends EventEmitter {`
`375`	`375`	`throw new Error("Duration must be an integer value in milliseconds.");`
`376`	`376`	`}`
`377`	`377`
`378`		`- const start = Date.now();`
`379`		`-`
`380`	`378`	`// The lock has already expired.`
`381`	`379`	`if (existing.expiration < Date.now()) {`
`382`	`380`	`throw new ExecutionError("Cannot extend an already-expired lock.", []);`
`383`	`381`	`}`
`384`	`382`
`385`		`- const { attempts } = await this._execute(`
	`383`	`+ const { attempts, start } = await this._execute(`
`386`	`384`	`this.scripts.extendScript,`
`387`	`385`	`existing.resources,`
`388`	`386`	`[existing.value, duration],`