Fix deprecated string increment on non-numeric string in nextHandle() (PHP 8.3+)#358
Merged
mikehaertl merged 1 commit intoJun 24, 2026
Conversation
Owner
|
@jaroslavlibal We have a psalm error now. Maybe you can mark that code part to be ignored by psalm somehow? |
… (PHP 8.3+) On PHP 8.3+ the $char++ operation in nextHandle() triggers "Increment on non-numeric string is deprecated, use str_increment() instead". This breaks projects that escalate deprecations to exceptions when adding files without explicit handles (e.g. new Pdf([$a, $b])). Use str_increment() on PHP 8.3+ and fall back to $char++ on older versions, which the library still supports (php >= 8.1). The handle sequence (A, B, ..., Z, AA, ...) is unchanged.
jaroslavlibal
force-pushed
the
fix-string-increment-deprecation
branch
from
b32b932 to
1f51671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On PHP 8.3+ the $char++ operation in nextHandle() triggers "Increment on non-numeric string is deprecated, use str_increment() instead". This breaks projects that escalate deprecations to exceptions when adding files without explicit handles (e.g. new Pdf([$a, $b])).
Use str_increment() on PHP 8.3+ and fall back to $char++ on older versions, which the library still supports (php >= 8.1). The handle sequence (A, B, ..., Z, AA, ...) is unchanged.
Fixes #357