Skip to content

Fix duplicate type check for StaticType.Byte in ClientTypeToDbTypeResolver#1213

Open
prjanitor wants to merge 1 commit intomikependon:masterfrom
prjanitor:prjanitor/00ba3eb60bf2af451097d5b6b20bc80b07382678
Open

Fix duplicate type check for StaticType.Byte in ClientTypeToDbTypeResolver#1213
prjanitor wants to merge 1 commit intomikependon:masterfrom
prjanitor:prjanitor/00ba3eb60bf2af451097d5b6b20bc80b07382678

Conversation

@prjanitor
Copy link
Copy Markdown

This PR removes an unreachable duplicate check for StaticType.Byte in the ClientTypeToDbTypeResolver.Resolve() method.

Issue: The conditional chain had two identical checks for StaticType.Byte:

  • First check at line 42 (reachable, correctly returns DbType.Byte)
  • Second check at line 87 (unreachable dead code)

Fix: Removed the duplicate else if (type == StaticType.Byte) block at line 87, which was never executed due to the earlier check in the conditional chain.

Impact: No functional change - this only removes dead code that was never reached. The behavior remains identical.


This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.

We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a .github/prjanitor.yml file with enabled: false to opt out explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant