Add a spec that shows how each-* breaks updates on the root model.#630
Open
eigood wants to merge 1 commit into
Open
Add a spec that shows how each-* breaks updates on the root model.#630eigood wants to merge 1 commit into
eigood wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
each-* copies the model referenced in the binding/view; when doing so, the event listeners attached that model are lost. As such, if the base model gets updated, the clone of the model in each-* doesn't see the changes.
My suggested fix is to add a "clone" method to the adapter.
There are other similar issues in the View class, but those aren't exposed with this spec.