Add support for multi-value aud claims#86
Open
glimberg wants to merge 1 commit into
Open
Conversation
Introduces a StringOrVec struct and custom serializer/deserialzer for the aud claim. Fixes Issue mikkyang#83
Author
|
@mikkyang If you can look at this ASAP, it'd be much appreciated. Need to get a new release out with this change incorporated. Have a deadline of Wednesday, June 22 to get a release going. |
|
This PR covers deserializing the How about an |
gbrlsnchs
reviewed
Mar 12, 2023
|
|
||
| /// Struct to handle the `aud` field because the JWT spec says that | ||
| /// it can be either a string or an array of strings. | ||
| /// [Audience Claim Specificatgion](https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3). |
There was a problem hiding this comment.
Suggested change
| /// [Audience Claim Specificatgion](https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3). | |
| /// [Audience Claim Specification](https://datatracker.ietf.org/doc/html/rfc7519#section-4.1.3). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a StringOrVec struct and custom serializer/deserialzer for
the aud claim.
Fixes Issue #83