Add EdDSA (Ed25519) signature support via ed25519-dalek#97
Open
flying-kestrel wants to merge 4 commits into
Open
Add EdDSA (Ed25519) signature support via ed25519-dalek#97flying-kestrel wants to merge 4 commits into
flying-kestrel wants to merge 4 commits into
Conversation
|
This is very cool, great job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR based on top of #96 that further expands support for EdDSA keys, this time in
algorithm::ed25519_dalek, via theed25519_dalekcrate.The rationale for adding a second mechanism to verify Ed25519 signatures is that OpenSSL is sometimes far too heavyweight of a solution; dalek is also a pure-Rust implementation, which helps for porting to less-supported architectures.