Profiles and Parameters update#23
Open
xptsp wants to merge 2 commits into
Open
Conversation
1) Refactored code to add `boot`, `shutdown`, `suspend`, `wake`, `hibernate`, `restore`, `recording`, and `voice` profiles. 2) Added `nuc_led_profiles` parameter to the module to allow mass setting of all profiles at module load time. 3) Added `debug` parameter to allow calls to dmesg to indicate which parameter is invalid. 4) Added `hibernate_same` parameter to tell the module to treat hibernation and suspension events seperately or the same. 5) Added code to add `current` to each setting so that profiles can specify a particular setting to change (ie: brightness) without affecting other settings. 6) Added code to allow use of numbers instead of labels (ie: `power`, `blink_fast`, etc) in order to allow for shorter strings when passing all profiles to the module at one time. 7) Modified `Makefile` so that `dkms.conf` is updated with version number in `Makefile` before building. 8) Modified `acpi_write_read` to use internal buffer for its playpen, instead of allocating seperate memory. Also implemented process blocking code to avoid unwanted buffer corruption. 9) Updated `README.md` with a ton of new information pertaining to the modifications I've made to the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to add
boot,shutdown,suspend,wake,hibernate,restore,recording, andvoiceprofiles.Added
nuc_led_profilesparameter to the module to allow mass setting of all profiles at module load time.Added
debugparameter to allow calls to dmesg to indicate which parameter is invalid.Added
hibernate_sameparameter to tell the module to treat hibernation and suspension events seperately or the same.Added code to add
currentto each setting so that profiles can specify a particular setting to change (ie: brightness) without affecting other settings.Added code to allow use of numbers instead of labels (ie:
power,blink_fast, etc) in order to allow for shorter strings when passing all profiles to the module at one time.Modified
Makefileso thatdkms.confis updated with version number inMakefilebefore building.Modified
acpi_write_readto use internal buffer for its playpen, instead of allocating seperate memory. Also implemented process blocking code to avoid unwanted buffer corruption.Updated
README.mdwith a ton of new information pertaining to the modifications I've made to the code.