feat: more tests

Author: milsanore

.github/workflows/clean_build_test.yml

@@ -11,30 +11,19 @@ on:
 # workflow_dispatch: # Allows manual triggering
 
 jobs:
-  format:
-    runs-on: ubuntu-latest
-    container:
-      image: ghcr.io/milsanore/tradercppbuild:v1.6
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          # if commit ref not set, revert to github-set commit
-          ref: ${{ inputs.ref || github.ref }}
-      - name: clang-format
-        run: hooks/check_clang_format.sh
-
   build_and_test:
-    needs: format
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/milsanore/tradercppbuild:v1.6
+      image: ghcr.io/milsanore/tradercppbuild:v1.7
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
+      - name: clang-format
+        run: hooks/check_clang_format.sh
+
       - name: Restore Conan cache
         uses: actions/cache@v4
         with:
@@ -53,11 +42,11 @@ jobs:
           set -e
           cmake --preset=debug
           cmake --build --preset=debug
-          ctest --preset=debug
 
       - name: Test
         run: |
           set -e
+          ctest -j$(nproc) --preset=debug
           # `lcov` FOR CODECOV
           lcov --gcov-tool gcov \
             --capture \

.github/workflows/release.yml

@@ -9,7 +9,7 @@ jobs:
   build_release:
     runs-on: ubuntu-latest
     container:
-      image: ghcr.io/milsanore/tradercppbuild:v1.6
+      image: ghcr.io/milsanore/tradercppbuild:v1.7
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4

Dockerfile_build

@@ -1,5 +1,5 @@
 #############################################
-# milss/tradercppbuild:v1.6
+# milss/tradercppbuild:v1.7
 # Build container for tradercpp
 # Published to dockerhub in order to accelerate github actions
 # Uses:
@@ -70,6 +70,9 @@ RUN echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-18 main" > /etc/ap
 RUN apt update && apt install -y --no-install-recommends \
     clang-format-18 \
     clang-tidy-18 \
+    libc++-18-dev \
+    libclang-18-dev \
+    libclang-rt-18-dev \
     && rm -rf /var/lib/apt/lists/*
 
 RUN update-alternatives --install /usr/bin/clang-format clang-format /usr/bin/clang-format-18 100 && \

Makefile

@@ -54,7 +54,7 @@ build-release:
 test:
 	cmake --preset debug
 	cmake --build --preset=debug
-	ctest --preset=debug
+	ctest -j$(shell nproc) --preset=debug
 	lcov --gcov-tool gcov --capture --directory . --output-file lcov.info
 	source .venv/bin/activate && \
 		gcovr -r . --exclude 'tests/*' --sonarqube -o sonar-coverage.xml
@@ -63,8 +63,7 @@ test:
 .PHONY: tidy
 tidy:
 	find src/ tests/ \( -name '*.cpp' -o -name '*.hpp' -o -name '*.c' -o -name '*.h' \) -exec clang-format -i {} +	
-	find tests/ -name '*.cpp' | xargs clang-tidy -p build/Debug --fix --format-style=.clang-format
-	find src/   -name '*.cpp' | xargs clang-tidy -p build/Debug --fix --format-style=.clang-format
+	hooks/check_clang_tidy.sh
 
 ## run-debug: 🏃‍♂️  run the app (debug) (don't forget `withenv`)
 .PHONY: run-debug
@@ -76,3 +75,21 @@ run-debug:
 .PHONY: run-release
 run-release:
 	build/Release/tradercpp
+
+# CONTAINERISATION RECIPES ----------------------------------------------------
+
+## build-container: 🚢 create the docker container for building the app (hosted on dockerhub and ghcr)
+.PHONY: build-container
+build-container:
+	IMAGE_VERSION=
+	@if [ -z "$(IMAGE_VERSION)" ]; then \
+		echo "Error: IMAGE_VERSION is not set"; \
+		echo "(you can set it on the command line like so: \`make build-container IMAGE_VERSION=1.7\`)"; \
+		exit 1; \
+	fi
+	docker build -f Dockerfile_build -t milss/tradercppbuild:latest -t milss/tradercppbuild:v$(IMAGE_VERSION) .
+
+## docker: 🚢 create an app docker image
+.PHONY: docker
+docker:
+	docker build .

README.md

@@ -148,7 +148,7 @@ NB: this app uses `make` as a recipe book, but it's not essential:
   - ✅ coverage gutters
   - ✅ dependency injection
   - integration test with mocked Binance server
-  - UI snapshot testing
+  - FTXUI snapshot testing
 - performance
   - ✅ store prices and sizes as integrals (ticks as `uint64_t`) for performance
   - release compile flags

docs/make-menu.png

@@ -4,13 +4,14 @@
 # check_clang_tidy.sh
 # checks for any lint warnings and errors out.
 # does not modify files in-place.
+# uses run-clang-tidy for parallel execution.
 ################################################################
 
 set -euo pipefail
 
-echo ">> Checking for clang-tidy warnings in src/..."
+echo ">> Checking for clang-tidy warnings..."
 
-CLANG_TIDY_BIN="clang-tidy"
+CLANG_TIDY_BIN="run-clang-tidy-18"
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 BUILD_DIR="$SCRIPT_DIR/../build/Debug"
 
@@ -20,21 +21,17 @@ if [ ! -f "$BUILD_DIR/compile_commands.json" ]; then
     exit 1
 fi
 
-files=$(find "$SCRIPT_DIR"/../src/ \( -name '*.cpp' -o -name '*.c' \) | sort)
-tidy_errors=0
-for file in $files; do
-    echo "Running clang-tidy on $file"
-    $CLANG_TIDY_BIN "$file" -p "$BUILD_DIR" > tidy_output.txt 2>&1 || true
-    if grep -q "warning:" tidy_output.txt; then
-        echo "clang-tidy warnings found in file, exiting. file: [$file] warnings:"
-        cat tidy_output.txt
-        tidy_errors=1
-        break
-    fi
-done
-rm tidy_output.txt
-
-if [ $tidy_errors -ne 0 ]; then
-    echo "ERROR: clang-tidy found warnings. Try \`make tidy\`"
+# Run run-clang-tidy in parallel on src/ and tests/ directories
+# no -fix flag to just report warnings/errors
+output=$($CLANG_TIDY_BIN -p "$BUILD_DIR" -j "$(nproc)" -header-filter='src/.*|tests/.*' src tests 2>&1) || true
+
+echo "$output"
+
+# Check if output contains any warnings or errors
+if echo "$output" | grep -qE "warning:|error:"; then
+    echo "ERROR: clang-tidy found warnings or errors. Try \`make tidy\`"
     exit 1
 fi
+
+echo "..."
+echo "No clang-tidy warnings found."

hooks/check_clang_tidy.sh

@@ -32,6 +32,10 @@ class Auth final : public IAuth {
 
   const std::string& get_api_key() const override;
 
+  /// Fetch a 32-byte Ed25519 seed from a private key PEM file (using OpenSSL)
+  /// @return 32-byte Ed25519 seed
+  std::vector<unsigned char> get_seed_from_pem() const;
+
   void clear_keys() override;
 
  private:
@@ -41,9 +45,6 @@ class Auth final : public IAuth {
 
   std::string& api_key_;
   std::string& private_pem_path_;
-  /// Fetch a 32-byte Ed25519 seed from a private key PEM file (using OpenSSL)
-  /// @return 32-byte Ed25519 seed
-  std::vector<unsigned char> get_seed_from_pem() const;
 };
 
 }  // namespace binance

src/binance/auth.h

@@ -7,7 +7,7 @@ namespace core {
 /// @brief basic bid/ask level
 struct BidAsk {
  public:
-  BidAsk() {};
+  BidAsk() = default;
   explicit BidAsk(u_int64_t bidsz, u_int64_t bidpx, u_int64_t askpx, u_int64_t asksz)
       : bid_sz(bidsz), bid_px(bidpx), ask_px(askpx), ask_sz(asksz) {}
 

src/core/bid_ask.h

@@ -28,8 +28,8 @@ int main() {
   b_worker.start();
 
   // ui app (reads from Binance's queues)
-  auto ui = ui::App::from_env(b_worker.get_order_queue(), b_worker.get_trade_queue(),
-                              b_conf.MAX_DEPTH);
+  auto ui =
+      ui::App::from_env(b_worker.get_order_queue(), b_worker.get_trade_queue(), b_conf);
   ui.start();
 
   if (ui.thread_exception) {