fix: clang-tidy

Author: milsanore

Makefile

@@ -49,7 +49,7 @@ test:
 ## tidy: 🧹 tidy things up before committing code
 .PHONY: tidy
 tidy:
-	find src/ tests/ -name '*.cpp' | xargs clang-tidy -p build/Debug --fix --format-style=.clang-format
+	find src/ -name '*.cpp' | xargs clang-tidy -p build/Debug --fix --format-style=.clang-format
 	find src/ tests/ \( -name '*.cpp' -o -name '*.hpp' -o -name '*.c' -o -name '*.h' \) -exec clang-format -i {} +	
 
 ## build-release: 🔨🔨 compile (prod)

README.md

@@ -118,6 +118,7 @@ a proof-of-concept, showcasing some c++ coding combined with some fintech concep
   - decimal type
   - zeromq + protobufs?
   - shellcheck?
+  - conan build_requires
 - deployment
   - terraform
 

hooks/check_clang_tidy.sh

@@ -20,7 +20,7 @@ if [ ! -f "$BUILD_DIR/compile_commands.json" ]; then
     exit 1
 fi
 
-files=$(find "$SCRIPT_DIR"/../src/ "$SCRIPT_DIR"/../tests/ \( -name '*.cpp' -o -name '*.c' \))
+files=$(find "$SCRIPT_DIR"/../src/ \( -name '*.cpp' -o -name '*.c' \))
 tidy_errors=0
 for file in $files; do
     echo "Running clang-tidy on $file"

hooks/pre-commit

@@ -13,6 +13,6 @@ DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # Run subscripts
 echo "Running strict pre-commit checks on src/ and tests/"
-# bash "$DIR/check_clang_tidy.sh"
+bash "$DIR/check_clang_tidy.sh"
 bash "$DIR/check_clang_format.sh"
 echo "✅ Pre-commit checks passed on full codebase."

src/ui/TableApp.cpp

@@ -62,8 +62,8 @@ ftxui::Element orderbookToTable(OrderBook &ob) {
   // ─────────── Data Rows ───────────
   const std::vector<BidAsk> x = ob.toVector();
   constexpr size_t max_rows = 15;
-  const int rowCount = std::min(x.size(), max_rows);
-  for (int i = 0; i < rowCount; ++i) {
+  const size_t rowCount = std::min(x.size(), max_rows);
+  for (size_t i = 0; i < rowCount; ++i) {
     ftxui::Elements cells;
     cells.push_back(ftxui::text(Pad(x[i].bid_sz, column_width)));
     cells.push_back(ftxui::text(Pad(x[i].bid_px, column_width)));
@@ -122,15 +122,18 @@ void TableApp::pollQueue(const std::stop_token &stoken) {
     /// Performs an adaptive backoff by spinning then sleeping, increasing sleep
     /// time exponentially. Yield 10x times, followed by a 2x sleep capped at
     /// 1ms
+    constexpr int INITIAL_SLEEP_US = 10;
     int spinCount = 0;
-    int sleepTimeUs = 10;
+    int sleepTimeUs = INITIAL_SLEEP_US;
     auto adaptiveBackoff = [&spinCount, &sleepTimeUs]() {
-      if (spinCount < 10) {
+      constexpr int MIN_SPINS = 10;
+      constexpr int MAX_SLEEP_US = 1000;
+      if (spinCount < MIN_SPINS) {
         ++spinCount;
         std::this_thread::yield();
       } else {
         std::this_thread::sleep_for(std::chrono::microseconds(sleepTimeUs));
-        sleepTimeUs = std::min(sleepTimeUs * 2, 1000);
+        sleepTimeUs = std::min(sleepTimeUs * 2, MAX_SLEEP_US);
       }
     };
 
@@ -161,7 +164,7 @@ void TableApp::pollQueue(const std::stop_token &stoken) {
 
       // Reset backoff state
       spinCount = 0;
-      sleepTimeUs = 10;
+      sleepTimeUs = INITIAL_SLEEP_US;
     }
     spdlog::info("closing worker thread...");
   }

src/utils/Threading.cpp

@@ -10,10 +10,12 @@
 
 namespace Utils {
 
+constexpr int MAX_STRING_LENGTH = 15;
+
 void Threading::set_thread_name(const std::string &name) {
 #if defined(__linux__)
   // Linux: Limit is 16 bytes including null terminator
-  pthread_setname_np(pthread_self(), name.substr(0, 15).c_str());
+  pthread_setname_np(pthread_self(), name.substr(0, MAX_STRING_LENGTH).c_str());
 
 #elif defined(__APPLE__)
   // macOS: Only supports setting name from within the thread