fix: clang-tidy fixed files

Author: milsanore

src/binance/Auth.cpp

@@ -21,7 +21,9 @@ namespace Binance {
 
 Auth::Auth(std::string &apiKey, std::string &privatePemPath)
     : apiKey_(apiKey), privatePemPath_(privatePemPath) {
-  if (sodium_init() < 0) throw std::runtime_error("libsodium failed to initialize");
+  if (sodium_init() < 0) {
+    throw std::runtime_error("libsodium failed to initialize");
+  }
 }
 
 const std::string &Auth::getApiKey() const { return apiKey_; }
@@ -34,16 +36,23 @@ std::string Auth::signPayload(const std::string &payload) {
 
 std::vector<unsigned char> Auth::getSeedFromPem() const {
   FILE *fp = fopen(privatePemPath_.c_str(), "r");
-  if (!fp) throw std::runtime_error("Failed to open PEM file");
+  if (fp == nullptr) {
+    throw std::runtime_error("Failed to open PEM file");
+  }
   EVP_PKEY *pkey = PEM_read_PrivateKey(fp, nullptr, nullptr, nullptr);
   fclose(fp);
-  if (!pkey) throw std::runtime_error("Failed to read private key from PEM");
+  if (pkey == nullptr) {
+    throw std::runtime_error("Failed to read private key from PEM");
+  }
 
   size_t len = 32;  // Ed25519 private key seed size
   std::vector<unsigned char> seed(len);
-  if (EVP_PKEY_get_raw_private_key(pkey, seed.data(), &len) != 1)
+  if (EVP_PKEY_get_raw_private_key(pkey, seed.data(), &len) != 1) {
     throw std::runtime_error("Failed to get raw private key");
-  if (len != 32) throw std::runtime_error("Unexpected private key length");
+  }
+  if (len != 32) {
+    throw std::runtime_error("Unexpected private key length");
+  }
 
   EVP_PKEY_free(pkey);
   return seed;
@@ -56,8 +65,9 @@ std::string Auth::signPayload(const std::string &payload,
   unsigned char sk[crypto_sign_SECRETKEYBYTES];  // 64 bytes
 
   // Generate keypair from seed
-  if (crypto_sign_seed_keypair(pk, sk, seed.data()) != 0)
+  if (crypto_sign_seed_keypair(pk, sk, seed.data()) != 0) {
     throw std::runtime_error("Failed to generate keypair from seed");
+  }
 
   unsigned char sig[crypto_sign_BYTES];
   if (crypto_sign_detached(sig, nullptr,

src/binance/Config.cpp

@@ -23,7 +23,7 @@ std::string getEnvOrThrow(const char *key) {
   throw std::runtime_error(std::format("envvar not defined, key [{}]", key));
 };
 
-// TODO: for keys, use `std::vector<unsigned char>` instead of string
+// TODO(mils): for keys, use `std::vector<unsigned char>` instead of string
 
 /// @brief load Binance configuration from env
 /// (static member function)
@@ -35,7 +35,9 @@ Config Config::fromEnv() {
   const std::string instStr = getEnvOrThrow("SYMBOLS");
   std::vector<std::string> symbols;
   for (auto inst : std::views::split(instStr, ',')) {
-    if (inst.size() > 0) symbols.emplace_back(inst.begin(), inst.end());
+    if (!inst.empty()) {
+      symbols.emplace_back(inst.begin(), inst.end());
+    }
   }
 
   // copy

src/binance/Worker.cpp

@@ -22,7 +22,7 @@ Worker::Worker(std::unique_ptr<FixApp> app,
                std::unique_ptr<FIX::SessionSettings> settings,
                std::unique_ptr<FIX::FileLogFactory> fileLogFactory,
                std::unique_ptr<FIX::SocketInitiator> initiator,
-               std::function<void(std::stop_token)> task)
+               const std::function<void(std::stop_token)> &task)
     : app_(std::move(app)),
       store_(std::move(fileStoreFactory)),
       settings_(std::move(settings)),
@@ -31,7 +31,7 @@ Worker::Worker(std::unique_ptr<FixApp> app,
       workerTask_(task) {
   // default behaviour
   if (!task) {
-    workerTask_ = ([this](std::stop_token stoken) {
+    workerTask_ = ([this](const std::stop_token &stoken) {
       Utils::Threading::set_thread_name("tradercppFIX");
       // NB: SocketInitiator::start() is a blocking call, so the stop_token
       // cannot cancel the thread. NB: The `stop()` function has to forcibly
@@ -69,7 +69,9 @@ void Worker::start() {
 
 void Worker::stop() {
   try {
-    if (initiator_) initiator_->stop();  // TODO: does this need a try/catch?
+    if (initiator_) {
+      initiator_->stop();  // TODO(mils): does this need a try/catch?
+    }
     spdlog::info("stopped FIX session");
   } catch (const std::exception &e) {
     spdlog::error("error stopping binance FIX session, error [{}]", e.what());

src/binance/Worker.h

@@ -24,7 +24,7 @@ class Worker final {
          std::unique_ptr<FIX::SessionSettings> settings,
          std::unique_ptr<FIX::FileLogFactory> fileLogFactory,
          std::unique_ptr<FIX::SocketInitiator> initiator,
-         std::function<void(std::stop_token)> task = {});
+         const std::function<void(std::stop_token)> &task = {});
   /// @brief factory for concrete Binance instances, using config
   /// @param conf binance configuration parameters
   /// @return

src/ui/OrderBook.cpp

@@ -10,11 +10,11 @@ OrderBook::OrderBook(std::map<double, double, std::greater<>> bidMap,
     : bidMap_(std::move(bidMap)), askMap_(std::move(askMap)) {}
 
 // move constructor
-OrderBook::OrderBook(OrderBook &&other) noexcept {
+OrderBook::OrderBook(OrderBook &&other) noexcept
+    : bidMap_(std::move(other.bidMap_)), askMap_(std::move(other.askMap_)) {
   // lock other.mutex_ to ensure safe access to its internal maps while moving
   std::lock_guard lock(other.mutex_);
-  bidMap_ = std::move(other.bidMap_);
-  askMap_ = std::move(other.askMap_);
+
   // mutex_ does not move; each instance has its own mutex
 }
 
@@ -31,7 +31,7 @@ OrderBook &OrderBook::operator=(OrderBook &&other) noexcept {
 std::vector<BidAsk> OrderBook::toVector() {
   std::lock_guard lock(mutex_);
   const size_t rowCount = std::max(bidMap_.size(), askMap_.size());
-  // TODO: could this be a pre-allocated/reusable vector with exactly 5000
+  // TODO(mils): could this be a pre-allocated/reusable vector with exactly 5000
   // entries?
   std::vector<BidAsk> v(rowCount);
   // bids

src/ui/TableApp.cpp

@@ -13,6 +13,7 @@
 #include <mutex>
 #include <string>
 #include <thread>
+#include <utility>
 #include <vector>
 
 #include "./../utils/Threading.h"
@@ -25,7 +26,9 @@ namespace UI {
 
 // Helper to pad or truncate a string to a fixed width
 std::string Pad(const std::string &input, const size_t width) {
-  if (input.size() >= width) return input.substr(0, width);
+  if (input.size() >= width) {
+    return input.substr(0, width);
+  }
 
   std::string result = input;
   result.resize(width, ' ');
@@ -91,7 +94,7 @@ TableApp::TableApp(
       workerTask_(std::move(task)) {
   // default behaviour
   if (!workerTask_) {
-    workerTask_ = ([this](std::stop_token stoken) {
+    workerTask_ = ([this](const std::stop_token &stoken) {
       Utils::Threading::set_thread_name("tradercppUI");
       pollQueue(stoken);
       spdlog::info("started polling queue on background thread");
@@ -101,7 +104,7 @@ TableApp::TableApp(
 
 // main thread
 void TableApp::start() {
-  // TODO: why does the order of these two items affect the rendered result?
+  // TODO(mils): why does the order of these two items affect the rendered result?
 
   // start worker thread
   worker_ = std::jthread(workerTask_);
@@ -112,7 +115,7 @@ void TableApp::start() {
 }
 
 // worker thread
-void TableApp::pollQueue(std::stop_token stoken) {
+void TableApp::pollQueue(const std::stop_token &stoken) {
   try {
     /// Adaptive backoff strategy for spin+sleep polling
     /// Performs an adaptive backoff by spinning then sleeping, increasing sleep
@@ -135,7 +138,9 @@ void TableApp::pollQueue(std::stop_token stoken) {
     while (!stoken.stop_requested()) {
       std::shared_ptr<const FIX44::Message> msg;
       while (!queue_.try_dequeue(msg)) {
-        if (stoken.stop_requested()) return;
+        if (stoken.stop_requested()) {
+          return;
+        }
         adaptiveBackoff();
       }
 
@@ -159,7 +164,7 @@ void TableApp::pollQueue(std::stop_token stoken) {
     }
     spdlog::info("closing worker thread...");
   }
-  // TODO: log error
+  // TODO(mils): log error
   catch (const std::exception &e) {
     spdlog::error("error in ui worker thread, error [{}]", e.what());
     thread_exception = std::current_exception();

src/ui/TableApp.h

@@ -40,7 +40,7 @@ class TableApp {
   moodycamel::ConcurrentQueue<std::shared_ptr<const FIX44::Message>> &queue_;
   /// @brief poll queue for any new FIX messages, update order book
   /// @param stoken
-  void pollQueue(std::stop_token stoken);
+  void pollQueue(const std::stop_token &stoken);
 };
 
 }  // namespace UI