fix: shellcheck + housekeeping

Author: milsanore

Makefile

@@ -85,8 +85,8 @@ bench:
 .PHONY: tidy
 tidy:
 	find src/ tests/ benchmarks/ \( -name '*.cpp' -o -name '*.hpp' -o -name '*.c' -o -name '*.h' \) -exec clang-format -i {} +	
-	hooks/check_clang_tidy.sh
 	hooks/check_shell.sh
+	hooks/check_clang_tidy.sh
 
 ## run-debug: 🏃‍♂️ run the app (debug) (don't forget `withenv`)
 .PHONY: run-debug

hooks/pre-commit

@@ -13,15 +13,17 @@ DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 
 # Run subscripts
 
-echo "Running strict pre-commit checks (clang-tidy, clang-format, build-debug)..."
+echo "Running strict pre-commit checks (clang-format, shellcheck, clang-tidy, build-debug)..."
+
+bash "$DIR/check_clang_format.sh"
+
+bash "$DIR/check_shell.sh"
 
 # TODO(mils): does this also need to be converted to:
 # `git diff -U0 origin/master...HEAD -- '*.cpp'`
 git diff -U0 master...HEAD -- '*.cpp' | \
   clang-tidy-diff-18.py -p1 -path "$DIR/../build/Debug"
 
-bash "$DIR/check_clang_format.sh"
-
 make build-debug
 
 echo "✅ Pre-commit checks passed on full codebase."

scripts/pin_cpus.sh

@@ -55,7 +55,7 @@ nodes_used=$(for cpu in $(expand_cpu_range "$CPU_SET_RANGE"); do
         cpulist_file="$node_dir/cpulist"
         [[ -f $cpulist_file ]] || continue
         if grep -qE "(^|,)$cpu($|,|-)" "$cpulist_file"; then
-            echo "$(basename "$node_dir" | sed 's/node//')"
+            basename "$node_dir" | sed 's/node//'
         fi
     done
 done | sort -u)

scripts/pin_irqs.sh

@@ -38,11 +38,11 @@ cpu_to_mask() {
     IFS=',' read -ra parts <<< "$1"
     for part in "${parts[@]}"; do
         if [[ $part =~ ^([0-9]+)-([0-9]+)$ ]]; then
-            for ((i=${BASH_REMATCH[1]}; i<=${BASH_REMATCH[2]}; i++)); do
-                cpus+=($i)
+            for ((i=BASH_REMATCH[1]; i<=BASH_REMATCH[2]; i++)); do
+                cpus+=("$i")
             done
         else
-            cpus+=($part)
+            cpus+=("$part")
         fi
     done
 
@@ -62,7 +62,7 @@ for irq in /proc/irq/*/smp_affinity; do
     [[ -f $irq ]] || continue 
     # Check if writable
     if [[ ! -w "$irq" ]]; then
-        echo "skipping IRQ, smp_affinity not writable. IRQ [$(basename $(dirname $irq))]"
+        echo "skipping IRQ, smp_affinity not writable. IRQ [$(basename "$(dirname "$irq")")]"
         continue
     fi
     # read current mask
@@ -75,7 +75,7 @@ for irq in /proc/irq/*/smp_affinity; do
     new_hex=$(printf "%x" "$new_dec")
     # only write if different
     if [[ "$current" != "$new_hex" ]]; then
-        echo "moving IRQ off isolated CPUs. IRQ [$(basename $(dirname $irq))] old [$current] new [$new_hex]"
+        echo "moving IRQ off isolated CPUs. IRQ [$(basename "$(dirname "$irq")")] old [$current] new [$new_hex]"
         echo "$new_hex" > "$irq"
     fi
 done