feat: add pydantic-extra-types for enhanced coordinate handling and update weather settings

Author: milsman2

pyproject.toml

@@ -12,6 +12,7 @@ dependencies = [
     "loguru>=0.7.3",
     "pathlib>=1.0.1",
     "pydantic>=2.12.5",
+    "pydantic-extra-types>=2.11.0",
     "pydantic-settings>=2.12.0",
     "pyfiglet>=1.0.4",
     "pylint>=4.0.4",

src/sample_python_app/core/__init__.py

@@ -2,13 +2,14 @@
 Export core modules for use in other modules.
 """
 
-from sample_python_app.core.config import settings
+from sample_python_app.core.config import settings, weather_settings
 from sample_python_app.core.data_loader import fetch_astronomical_data_from_api
 from sample_python_app.core.display import display_astronomical_data
 from sample_python_app.core.logging import setup_logger
 
 __all__ = [
     "settings",
+    "weather_settings",
     "setup_logger",
     "display_astronomical_data",
     "fetch_astronomical_data_from_api",

src/sample_python_app/core/config.py

@@ -4,9 +4,22 @@
 
 from zoneinfo import ZoneInfo
 
+from pydantic_extra_types.coordinate import Coordinate, Latitude, Longitude
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 
+class WeatherSettings(BaseSettings):
+    """Weather-related settings."""
+
+    LOCATION: Coordinate = Coordinate(Latitude(29.8469), Longitude(-95.4689))
+
+    model_config = SettingsConfigDict(
+        env_file=".env",
+        env_file_encoding="utf-8",
+        case_sensitive=False,
+    )
+
+
 class Settings(BaseSettings):
     """Application settings display."""
 
@@ -26,3 +39,4 @@ def tz(self) -> ZoneInfo:
 
 
 settings = Settings()
+weather_settings = WeatherSettings()

src/sample_python_app/main.py

@@ -11,11 +11,12 @@
 from sample_python_app.core import (
     display_astronomical_data,
     fetch_astronomical_data_from_api,
+    weather_settings,
 )
 
 
 def run_app():
-    lat, lon = 29.8469, -95.4689
+    lat, lon = weather_settings.LOCATION.latitude, weather_settings.LOCATION.longitude
     try:
         astro = fetch_astronomical_data_from_api(lat, lon)
     except httpx.HTTPStatusError as e:

tests/test_config.py

@@ -0,0 +1,30 @@
+from sample_python_app.core.config import settings, weather_settings
+
+
+def test_settings_fields():
+    assert settings.APP_NAME == "python-app-template"
+    assert settings.DATE_FORMAT
+    assert settings.TIMEZONE
+
+
+def test_settings_tz_property():
+    tz = settings.tz
+    # ZoneInfo does not have a 'zone' attribute; use 'key' for the timezone name
+    assert tz.key == settings.TIMEZONE
+
+
+def test_weather_settings_location():
+    loc = weather_settings.LOCATION
+    assert loc.latitude == 29.8469
+    assert loc.longitude == -95.4689
+
+
+def test_settings_instantiation_and_model_config():
+    # Explicitly instantiate settings classes
+    s = type(settings)()
+    ws = type(weather_settings)()
+    # Access model_config (should exist and be a dict-like object)
+    assert hasattr(s, "model_config")
+    assert hasattr(ws, "model_config")
+    # Access tz property again for coverage
+    assert isinstance(s.tz, type(settings.tz))