Add flushAll/getFlushAllState#499
Merged
Merged
Conversation
Signed-off-by: yhmo <yihua.mo@zilliz.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yhmo
requested review from
Copilot
and removed request for
ArkaprabhaChakraborty and
xiaofan-luan
There was a problem hiding this comment.
Pull request overview
This PR adds v2 SDK support for Milvus FlushAll and GetFlushAllState, including public request/response types, client/connection plumbing, and tests.
Changes:
- Adds
FlushAll/GetFlushAllStatemethods toMilvusClientV2and implements the corresponding gRPC calls. - Introduces request/response classes for the new APIs.
- Adds unit and mocked integration tests for success, RPC failure, and server failure paths.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/include/milvus/MilvusClientV2.h |
Exposes new v2 client APIs and includes new request/response headers. |
src/include/milvus/request/utility/FlushAllRequest.h |
Defines public request parameters for FlushAll. |
src/include/milvus/request/utility/GetFlushAllStateRequest.h |
Defines public request parameters for polling flush-all state. |
src/include/milvus/response/utility/FlushAllResponse.h |
Defines public response containing the flush-all timestamp. |
src/include/milvus/response/utility/GetFlushAllStateResponse.h |
Defines public response containing flushed state. |
src/impl/request/utility/FlushAllRequest.cpp |
Implements FlushAllRequest accessors and fluent setters. |
src/impl/request/utility/GetFlushAllStateRequest.cpp |
Implements GetFlushAllStateRequest accessors and fluent setters. |
src/impl/response/utility/FlushAllResponse.cpp |
Implements FlushAllResponse accessors. |
src/impl/response/utility/GetFlushAllStateResponse.cpp |
Implements GetFlushAllStateResponse accessors. |
src/impl/MilvusClientV2Impl.h |
Declares new v2 implementation methods and helper. |
src/impl/MilvusClientV2Impl.cpp |
Implements FlushAll, wait-loop polling, and GetFlushAllState. |
src/impl/MilvusConnection.h |
Declares new connection-level gRPC wrappers. |
src/impl/MilvusConnection.cpp |
Implements new connection-level gRPC wrappers. |
test/it/mocks/MilvusMockedService.h |
Adds mocked service methods for the new RPCs. |
test/it/v1/TestFlushAll.cpp |
Adds mocked integration coverage for both new APIs. |
test/ut/request/TestUtilityRequests.cpp |
Adds request getter/setter unit tests. |
test/ut/response/TestUtilityResponses.cpp |
Adds response getter/setter unit tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #499 +/- ##
======================================
Coverage ? 77.40%
======================================
Files ? 302
Lines ? 13496
Branches ? 1320
======================================
Hits ? 10446
Misses ? 2940
Partials ? 110
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.