Expose CPPSTD configuration#505
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yhmo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR aims to make the Milvus C++ SDK’s C++ language standard configurable (rather than being hard-coded to C++14), by exposing the setting through CMake and the build script, and relaxing Conan’s enforced cppstd pinning.
Changes:
- Expose
CMAKE_CXX_STANDARDas an overridable CMake cache variable. - Add a
CPPSTDenvironment variable toscripts/build.shand pass it through to CMake. - Remove Conan recipe configuration that forcibly set
compiler.cppstd=14.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/build.sh | Introduces CPPSTD (default 14) and forwards it to -DCMAKE_CXX_STANDARD (and Conan host settings). |
| conanfile.py | Removes forced compiler.cppstd=14, leaving only a minimum-standard validation. |
| CMakeLists.txt | Makes CMAKE_CXX_STANDARD a cache variable so callers can override it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
===========================================
+ Coverage 53.47% 77.71% +24.23%
===========================================
Files 52 304 +252
Lines 4432 13654 +9222
Branches 0 1325 +1325
===========================================
+ Hits 2370 10611 +8241
- Misses 2062 2934 +872
- Partials 0 109 +109
🚀 New features to boost your workflow:
|
Signed-off-by: yhmo <yihua.mo@zilliz.com>
No description provided.