Skip to content

Expose CPPSTD configuration#505

Merged
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
yhmo:mm
Jun 5, 2026
Merged

Expose CPPSTD configuration#505
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
yhmo:mm

Conversation

@yhmo
Copy link
Copy Markdown
Collaborator

@yhmo yhmo commented Jun 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings June 4, 2026 11:19
@sre-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the Milvus C++ SDK’s C++ language standard configurable (rather than being hard-coded to C++14), by exposing the setting through CMake and the build script, and relaxing Conan’s enforced cppstd pinning.

Changes:

  • Expose CMAKE_CXX_STANDARD as an overridable CMake cache variable.
  • Add a CPPSTD environment variable to scripts/build.sh and pass it through to CMake.
  • Remove Conan recipe configuration that forcibly set compiler.cppstd=14.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
scripts/build.sh Introduces CPPSTD (default 14) and forwards it to -DCMAKE_CXX_STANDARD (and Conan host settings).
conanfile.py Removes forced compiler.cppstd=14, leaving only a minimum-standard validation.
CMakeLists.txt Makes CMAKE_CXX_STANDARD a cache variable so callers can override it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/build.sh
Comment thread CMakeLists.txt
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.71%. Comparing base (a0592aa) to head (b608a72).
⚠️ Report is 107 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #505       +/-   ##
===========================================
+ Coverage   53.47%   77.71%   +24.23%     
===========================================
  Files          52      304      +252     
  Lines        4432    13654     +9222     
  Branches        0     1325     +1325     
===========================================
+ Hits         2370    10611     +8241     
- Misses       2062     2934      +872     
- Partials        0      109      +109     
Files with missing lines Coverage Δ
src/impl/MilvusClientV2Impl.cpp 63.70% <100.00%> (ø)
src/impl/utils/ConnectionHandler.h 83.33% <ø> (ø)

... and 319 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment thread CMakeLists.txt
Comment thread scripts/build.sh
Comment thread conanfile.py
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M and removed size/S labels Jun 5, 2026
@sre-ci-robot sre-ci-robot merged commit f6ff5a7 into milvus-io:master Jun 5, 2026
12 checks passed
@mergify mergify Bot removed the ci-passed label Jun 5, 2026
@yhmo yhmo deleted the mm branch June 5, 2026 06:23
@mergify mergify Bot added the ci-passed label Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants