Skip to content

Commit 0fa5194

Browse files
DivyaDivya
authored andcommitted
Addressing review comments
Signed-off-by: Divya <DIVYA2@ibm.com>
1 parent a1cfa3e commit 0fa5194

2 files changed

Lines changed: 21 additions & 3 deletions

File tree

sdk-core/src/main/java/io/milvus/v2/client/ConnectConfig.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public class ConnectConfig {
4848
private String proxyAddress;
4949
private Boolean secure = false;
5050
private long idleTimeoutMs = TimeUnit.MILLISECONDS.convert(24, TimeUnit.HOURS);
51+
private boolean enablePrecheck = false; // default value is false
5152

5253
private SSLContext sslContext;
5354
// clientRequestId maintains a map for different threads, each thread can assign a specific id.
@@ -79,6 +80,7 @@ private ConnectConfig(ConnectConfigBuilder builder) {
7980
this.idleTimeoutMs = builder.idleTimeoutMs;
8081
this.sslContext = builder.sslContext;
8182
this.clientRequestId = builder.clientRequestId;
83+
this.enablePrecheck = builder.enablePrecheck;
8284
}
8385

8486
public static ConnectConfigBuilder builder() {
@@ -162,6 +164,9 @@ public String getProxyAddress() {
162164
return proxyAddress;
163165
}
164166

167+
public boolean isEnablePrecheck() {
168+
return enablePrecheck;
169+
}
165170
// Setters
166171
public void setUri(String uri) {
167172
if (uri == null) {
@@ -234,6 +239,10 @@ public void setSecure(Boolean secure) {
234239
this.secure = secure;
235240
}
236241

242+
public void setEnablePrecheck(boolean enablePrecheck) {
243+
this.enablePrecheck = enablePrecheck;
244+
}
245+
237246
public void setIdleTimeoutMs(long idleTimeoutMs) {
238247
this.idleTimeoutMs = idleTimeoutMs;
239248
}
@@ -301,6 +310,7 @@ public String toString() {
301310
", serverName='" + serverName + '\'' +
302311
", proxyAddress='" + proxyAddress + '\'' +
303312
", secure=" + secure +
313+
", enablePrecheck=" + enablePrecheck +
304314
", idleTimeoutMs=" + idleTimeoutMs +
305315
", sslContext=" + sslContext +
306316
", clientRequestId=" + clientRequestId +
@@ -328,6 +338,7 @@ public static class ConnectConfigBuilder {
328338
private long idleTimeoutMs = TimeUnit.MILLISECONDS.convert(24, TimeUnit.HOURS);
329339
private SSLContext sslContext;
330340
private ThreadLocal<String> clientRequestId;
341+
private boolean enablePrecheck = false;
331342

332343
public ConnectConfigBuilder uri(String uri) {
333344
if (uri == null) {
@@ -417,6 +428,11 @@ public ConnectConfigBuilder secure(Boolean secure) {
417428
return this;
418429
}
419430

431+
public ConnectConfigBuilder enablePrecheck(boolean enablePrecheck) {
432+
this.enablePrecheck = enablePrecheck;
433+
return this;
434+
}
435+
420436
public ConnectConfigBuilder idleTimeoutMs(long idleTimeoutMs) {
421437
this.idleTimeoutMs = idleTimeoutMs;
422438
return this;

sdk-core/src/main/java/io/milvus/v2/client/MilvusClientV2.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,11 @@ private void initServices(String dbName) {
132132
*/
133133
private void connect(ConnectConfig connectConfig) {
134134
this.connectConfig = connectConfig;
135-
validateHostname(connectConfig);
136-
validatePort(connectConfig);
137-
validateCert(connectConfig);
135+
if (connectConfig.isEnablePrecheck()) {
136+
validateHostname(connectConfig);
137+
validatePort(connectConfig);
138+
validateCert(connectConfig);
139+
}
138140
try {
139141
if (this.channel != null) {
140142
// close channel first

0 commit comments

Comments
 (0)